Expose patricia_search_all on SubnetTree

[ikbenale]

Note: there are some unrelated changes on SubnetTree_wrap.cc that appear when I make the project. First I assumed it was because I was using a newer version of SWIG, but I downloaded and compiled the one used in the file comments, 3.0.12, and I still got those discrepancies. If it's more convenient, I can manually edit those changes to omit unwanted lines.

[bbannier]

Note: there are some unrelated changes on SubnetTree_wrap.cc that appear when I make the project.

Yeah, I saw that to, there must have been something else about these files. The commit making the last update talks about keeping changes minimal, maybe there was some manual editing involved then.

For fixing a new runtime failure with e.g., python-3.11.9 we have merged a fix #38 which updates the generated files so you should see a smaller diff now. That PR also brings CI up to date (e.g., python-3.7 is not available anymore in macos CI). If you rebase your PR on the lasted HEAD you'll get these changes.

[ikbenale]

@bbannier rebased and now my diff looks clean 👍. I pushed the new version.

[awelzel]

First I assumed it was because I was using a newer version of SWIG, but I downloaded and compiled the one used in the file comments, 3.0.12, and I still got those discrepancies. If it's more convenient, I can manually edit those changes to omit unwanted lines.

Yeah, I saw that to, there must have been something else about these files. The commit making the last update talks about keeping changes minimal, maybe there was some manual editing involved then.

That was me: I've used swig 3.0.12 from Debian which carries a number of patches that change the generated output and that's how these got introduced. I confirm that by using an unaltered and pristine swig 3.0.12, the code isn't changed.

[awelzel]

@ikbenale - I've merged after adding a free() for the returned outlist to plug a memory leak.

Thanks for your contribution!

[ikbenale]

@awelzel awesome, thanks!

I've merged after adding a free()

Out of curiosity, where did you add this? I don't see that change on master 🤔

[awelzel]

The change is in the merge commit. This part look slightly different now:

pysubnettree/SubnetTree.cc

Lines 350 to 360 in ebca8ed

	int result = patricia_search_all(tree, sn, &outlist, &n);
	Deref_Prefix(sn);
	PyObject* list = PyList_New(n);
	for (int i = 0; i < n; i++) {
	PyObject* data = (PyObject*)outlist[i]->data;
	Py_INCREF(data);
	PyList_SetItem(list, i, data);
	}
	free(outlist);