Add bytes decoding from UTF-16
#1946
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbannier
force-pushed
the
topic/bbannier/issue-1788
branch
3 times, most recently
from
e78510a to
8711bff
Compare
rsmmr
reviewed
Dec 16, 2024
bbannier
force-pushed
the
topic/bbannier/issue-1788
branch
from
44df820 to
359c3f5
Compare
rsmmr
previously approved these changes
Dec 17, 2024
bbannier
force-pushed
the
topic/bbannier/issue-1788
branch
from
359c3f5 to
8dc1550
Compare
bbannier
commented
Dec 19, 2024
This was already exposed as a single type in Spicy and HILTI anyway. We also move `Charset` into the `unicode` namespace.
This allows a cleaner separation between `Bytes` as "bags of bytes" and `string` as "valid UTF8". Having such a clean separation will make adding support for more encodings less duplicative.
This parameter defaults to `DecodeErrorStrategy::REPLACE` like the previous implicit parameter used in the implementation.
This adds two new charsets `UTF16LE` and `UTF16BE` for little and big endian UTF16 respectively. We also clean up use of the Unicode replacement character to make it work consistently between UTF16 and UTF8. Closes #1788.
By passing in a `const std::string&` we would have incurred construction costs of an owning string when all we needed was a non-owning view. We also clean up the implementation of `startsWith` to use standard library functionality.
bbannier
force-pushed
the
topic/bbannier/issue-1788
branch
from
8dc1550 to
9a773ce
Compare
rsmmr
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1788.