WebSocket and logging test maintenance #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, these benchmarks would run after Zeek has decided to shut down, making Zeek's internal batching ineffective.
These were created by tunneling various traffic with wstunnel (HTTP downloads and SSH uploads and a tiny bit of SSL). Hook up the both, BinPac and Spicy versions to see improvements or regressions in Spicy over time. Here these run in 8.3 vs 14.4 seconds runtime, with bare mode taking some 3.5 seconds to process the pcap.
timwoj
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
The logging micro-benchmark change will skew the results, but unclear how useful the previous once were anyhow.
I think this is fine because you're typically only comparing short time windows, such as a PR vs a recent master branch. As long as we're getting re-runs of the benchmarks on the various release branches (I think that happens?), the long-term comparisons should be fine also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging micro-benchmark change will skew the results, but unclear how useful the previous once were anyhow. Might make sense to keep a hash of the micro-benchmark file in the results though to detect something like that.
Relates to zeek/zeek#3331