Follow-up for benchmarker #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After chatting with Robin, a jobs table would be good to store additional information. Also adds a bit of infrastructure for alembic based database migration. Haven't committed to using SQLAlchemy just yet, but depending on where things are going not totally off the table.
Populate the success/error columns of zeek_tests for missing results or unhandled exceptions.
timwoj
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alembicinfrastructure for database migrationzeek_teststableThis change invalidates the schema once more, but after that should try to use migrations properly.
This makes use of the additional information added here: zeek/zeek#3310