Supporting IPv6 addresses for the --controller option #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopheide-esnet
changed the title
|
I've added tests for specifying both v4 and v6 addresses with the --controller option and fixed a result bug that discovered. This should be good now. |
dopheide-esnet
changed the title
dopheide-esnet
changed the title
ckreibich
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Thanks Dop! We currently have no other testing of IPv6, I think — I should look into some of those for our cluster testsuite. But if this works for you, yay!
I looked at the ipaddress module and whether it stomachs [...] in its IPv6 handling, but unfortunately it doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally found out that the --controller option doesn't support IPv6 addresses, so here's a first attempt. I'm hoping to build test cases once I remember how to get those to run.