Upgrade required python version to 3.9, plus various linter fixes #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwoj
commented
Dec 5, 2024
ext/zeek.py
Outdated
| @@ -216,7 +211,7 @@ def add_target_and_index(self, name, sig, signode): | |||
| objects[key] = self.env.docname | |||
| self.update_type_map(name) | |||
|
|
|||
| indextext = self.get_index_text(name) | |||
| #indextext = self.get_index_text(name) | |||
There was a problem hiding this comment.
This line can probably just be deleted, like the others that were unused.
ckreibich
approved these changes
Dec 9, 2024
| from pygments.lexer import RegexLexer, bygroups, include, words, bygroups | ||
| from pygments.token import * | ||
| from pygments.lexer import RegexLexer, bygroups, include, words | ||
| from pygments.token import ( |
There was a problem hiding this comment.
Huh, this is quite cool — it actually expanded the *?
There was a problem hiding this comment.
No, this one I had to do manually
| ( | ||
| words( | ||
| ( | ||
| "any", |
There was a problem hiding this comment.
This is one of the rare places where the earlier form was slightly more meaningful because it grouped by context within a line. But, no biggie.
timwoj
force-pushed
the
topic/timw/python-upgrade
branch
from
b9fd865 to
fe96796
Compare
This is required by Python 3.13, which throws an error with any earlier version of Sphinx.
timwoj
force-pushed
the
topic/timw/python-upgrade
branch
from
fe96796 to
aceb13f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.