Require python 3.9, plus lots of linting and formatting fixes #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbannier
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
This is a huge PR 😬. I tried to review individual commits, but not all pass the pre-commit hooks individually. What I did instead was at the tip revert all non-linter changes to their version from master, automatically apply all changes and review the delta.
The changes look fine and mostly cosmetic to me, but you also fixed a number of true bugs (noted them with Uff comments in the review). I did not test how they changed behavior, but they looked reasonable to me.
Let's definitely add a GH job running pre-commit. It would also be great to have some CI running the test suite for the things we cover, but that might be hard. As is this package cannot be installed as a Python project.
timwoj
force-pushed
the
topic/timw/python-upgrade
branch
from
756dc28 to
32e19ce
Compare
This disables the format string finding (UP031) temporarily. It is handled in a separate commit because it's so many changes.
timwoj
force-pushed
the
topic/timw/python-upgrade
branch
2 times, most recently
from
352dd72 to
4cfc1d6
Compare
timwoj
force-pushed
the
topic/timw/python-upgrade
branch
from
4cfc1d6 to
a1ac7af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a basic pyproject.toml to this just for consistency with our other projects. I didn't add a setup.py because you will generally never install this package outside of a Zeek installation.