Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup.py dependency on uwsgi #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danmichaelo
Copy link

@danmichaelo danmichaelo commented Apr 19, 2019

This might at first sound like a silly request, but there are many ways to install uwsgi, and not all are understood by pip. If I have uwsgi installed through a package manager (apt install uwsgi uwsgi-plugin-python3 on Debian), I don't want to install another copy of uwsgi when I install Flask-uWSGI-WebSocket. Especially since uwsgi installation through pip is sometimes non-trivial, requiring a compiler and several libraries to be found.

With pip, I can use pip install Flask-uWSGI-WebSocket --no-deps to avoid uwsgi, but with pipenv no such flag seems to be available, so this is why I'm suggesting to remove uwsgi from setup.py.

Since uwsgi can be installed in other ways.
@frankier
Copy link

Another reason for wanting this is that if you use async then uwsgi has to be installed like so:

CFLAGS="-I/usr/local/include/python3.7/" UWSGI_PROFILE="asyncio" pip3 install --upgrade --force-reinstall --no-binary :all: uwsgi

There is no way to instruct pipenv, or in my case, poetry to do this -- currently I am therefore always installing uwsgi twice -- first the incorrect version and then the correct version over the top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants