-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds math opcodes #80
Open
3commascapital
wants to merge
6
commits into
zemse:v3
Choose a base branch
from
3commascapital:opcode-hunting
base: v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3commascapital
force-pushed
the
opcode-hunting
branch
from
September 3, 2024 18:42
b9df804
to
5961dc2
Compare
I think the main thing to discuss is the
|
any thoughts @zemse ? |
Sorry for the delay, I'll try to review this sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes print out math opcodes that take 2 inputs and push its result to the top of the stack. The list of operators and appropriate typing can be found in math2.ts. I found that it was a cleaner diff to break the switch pattern being used in opcodes/index.ts but I am willing to use it if required. I plan to add the 3 input opcodes as well. Happy to do these changes in pieces if desired.