Refactor ZenPinnedTabsStorage table creation logic for improved reada…

…bility and maintainability
zen-browser · Dec 19, 2024 · 77f26aa · 77f26aa
1 parent 1ab4af5
commit 77f26aa
Showing 1 changed file with 40 additions and 43 deletions.
diff --git a/src/browser/base/zen-components/ZenPinnedTabsStorage.mjs b/src/browser/base/zen-components/ZenPinnedTabsStorage.mjs
@@ -5,52 +5,49 @@ var ZenPinnedTabsStorage = {
   },
 
   async _ensureTable() {
-    return new Promise(async (resolve, reject) => {
-      await PlacesUtils.withConnectionWrapper('ZenPinnedTabsStorage._ensureTable', async (db) => {
-        console.log('ZenPinnedTabsStorage: Ensuring tables...');
-        // Create the pins table if it doesn't exist
-        await db.execute(`
-          CREATE TABLE IF NOT EXISTS zen_pins (
-        id INTEGER PRIMARY KEY,
-        uuid TEXT UNIQUE NOT NULL,
-        title TEXT NOT NULL,
-        url TEXT,
-        container_id INTEGER,
-        workspace_uuid TEXT,
-        position INTEGER NOT NULL DEFAULT 0,
-        is_essential BOOLEAN NOT NULL DEFAULT 0,
-        is_group BOOLEAN NOT NULL DEFAULT 0,
-        parent_uuid TEXT,
-        created_at INTEGER NOT NULL,
-        updated_at INTEGER NOT NULL,
-        FOREIGN KEY (parent_uuid) REFERENCES zen_pins(uuid) ON DELETE SET NULL
-            )
-        `);
-
-
-        // Create indices
-        await db.execute(`
-          CREATE INDEX IF NOT EXISTS idx_zen_pins_uuid ON zen_pins(uuid)
-        `);
+    await PlacesUtils.withConnectionWrapper('ZenPinnedTabsStorage._ensureTable', async (db) => {
+      console.log('ZenPinnedTabsStorage: Ensuring tables...');
+      // Create the pins table if it doesn't exist
+      await db.execute(`
+        CREATE TABLE IF NOT EXISTS zen_pins (
+      id INTEGER PRIMARY KEY,
+      uuid TEXT UNIQUE NOT NULL,
+      title TEXT NOT NULL,
+      url TEXT,
+      container_id INTEGER,
+      workspace_uuid TEXT,
+      position INTEGER NOT NULL DEFAULT 0,
+      is_essential BOOLEAN NOT NULL DEFAULT 0,
+      is_group BOOLEAN NOT NULL DEFAULT 0,
+      parent_uuid TEXT,
+      created_at INTEGER NOT NULL,
+      updated_at INTEGER NOT NULL,
+      FOREIGN KEY (parent_uuid) REFERENCES zen_pins(uuid) ON DELETE SET NULL
+          )
+      `);
 
-        await db.execute(`
-          CREATE INDEX IF NOT EXISTS idx_zen_pins_parent_uuid ON zen_pins(parent_uuid)
-        `);
 
-        // Create the changes tracking table if it doesn't exist
-        await db.execute(`
-          CREATE TABLE IF NOT EXISTS zen_pins_changes (
-            uuid TEXT PRIMARY KEY,
-            timestamp INTEGER NOT NULL
-          )
-        `);
+      // Create indices
+      await db.execute(`
+        CREATE INDEX IF NOT EXISTS idx_zen_pins_uuid ON zen_pins(uuid)
+      `);
 
-        // Create an index on the uuid column for changes tracking table
-        await db.execute(`
-          CREATE INDEX IF NOT EXISTS idx_zen_pins_changes_uuid ON zen_pins_changes(uuid)
-        `);
-        resolve();
-      });
+      await db.execute(`
+        CREATE INDEX IF NOT EXISTS idx_zen_pins_parent_uuid ON zen_pins(parent_uuid)
+      `);
+
+      // Create the changes tracking table if it doesn't exist
+      await db.execute(`
+        CREATE TABLE IF NOT EXISTS zen_pins_changes (
+          uuid TEXT PRIMARY KEY,
+          timestamp INTEGER NOT NULL
+        )
+      `);
+
+      // Create an index on the uuid column for changes tracking table
+      await db.execute(`
+        CREATE INDEX IF NOT EXISTS idx_zen_pins_changes_uuid ON zen_pins_changes(uuid)
+      `);
     });
   },