Removed ability to adjust density in CustomizeUI mode

[Richard-Woessner]

Added patch to remove the Density button from the Customize UI settings. This is to avoid user confusion

Issue #2636

After Update

Before Update

[Richard-Woessner]

This whole file is to test the Density button. I wasnt sure if there was a better way than commenting out the page, so let me know

[Tellinq]

Doesn't the Touch density work fine? From my testing Touch density isn't indicating any alignment anomalies.

For me - I use Touch on my 2n1 devices, so this would be a negative change if Density is outright removed. Are you unable to hide Compact only?

[MrPiggy105]

Compact works fine for me. The only confusion is perhaps confusing compact density with compact mode in Arc - we may want to rename it rather than remove it. I have a couple of friends who use compact density on Firefox and like it and I don't see why we should remove it from Zen.

[Tellinq]

If you’re going to hide the Density button, I would only do this on macOS since the Touch density is available on Windows and Linux which work fine.

I strongly advise against this change for all operating systems. I get why you’d do this since you’re on macOS where only Compact and Normal are present, but that doesn’t remain true on Windows and Linux.

If you want to do this in a smart manner in removing it, remove the Compact option entirely, and THEN if the density option still shows, remove the Density option IF only one option is shown.

[Richard-Woessner]

Maybe I'm wrong but the compact mode in the customizeUI options is different from zen's compact mode. The issue that this PR came from was from Linux but also caused an issue on my mac. I will test again and double check

[Tellinq]

And you're right that Compact density is different from Zen's compact mode (as compact mode is hiding one or both toolbars unless hovering, while density intends to change the height and width of toolbar elements) - but that's not my point.

My point is that Touch also exists and works fine. If you're removing Density altogether, you're then removing Touch when that is completely unnecessary.

Compact

Normal

Touch

Only issue I see with Compact is that the text alignment on tabs is not as ideal, while Normal and Touch are fine. This shouldn't need to warrant removing Density entirely - in my view what should be changed is just text alignment in Compact density. However if it's deemed unsupported then that's understandable. However, if you're going to remove anything related to the issue you're trying to solve, just remove Compact density as an available option, not Density.

If I'm being unclear... if you're going to remove anything... this is what you should remove, not what you are currently doing in your PR

---

For the record, not even the latest version of Firefox has Compact as available option (at least on Linux). This is simply all I'm asking out of this PR if ANYTHING regarding the issue you're trying to solve is to be removed

[Richard-Woessner]

I see what you mean now. Sorry I'm at work so I couldn't dig as deep as I should. You're right I didn't see Touch because I'm on a mac. I will wait for how @mauro-balades wants to handle this. If he would rather, I fix the bug causing the padding issues or remove this feature because I would imagine that this would cause a lot more of a headache to make sure any change works well with all the Density options.

I will convert this into a draft and wait, but thanks for pointing this out

[Richard-Woessner]

Okay I stand corrected this seems to be fixed now. Im going to close this but keep up a PR to remove toolbars button