Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Toolbar button in customize mode to reduce user confusion #2730

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

Richard-Woessner
Copy link
Contributor

This isnt an issue but wanted to give mauro-balades the option to add this after merging PR I-2676, because they are similar issues

image image

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Enhancement labels Nov 7, 2024
@Richard-Woessner Richard-Woessner changed the title Hide density button in customize mode to reduce user confusion Hide Toolbar button in customize mode to reduce user confusion Nov 7, 2024
@Richard-Woessner Richard-Woessner marked this pull request as draft November 7, 2024 20:59
@Richard-Woessner
Copy link
Contributor Author

Update

Before

image

After

image

@Richard-Woessner Richard-Woessner marked this pull request as ready for review November 7, 2024 23:00
@mr-cheff
Copy link
Member

mr-cheff commented Nov 8, 2024

Why make a patch when you can just add it to zen-single-components.css?

@Richard-Woessner
Copy link
Contributor Author

Sorry I didn't know that was a choice. Ill adjust it today

@Richard-Woessner
Copy link
Contributor Author

Sorry I didnt know that was a choice. Ill adjust it today

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 11, 2024
@Richard-Woessner
Copy link
Contributor Author

@mauro-balades Fixed, and Ill take note to use those css files for cases like these from now on

@mr-cheff
Copy link
Member

Thanks!

@mr-cheff mr-cheff merged commit 12afbcd into zen-browser:dev Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: To Deploy
Development

Successfully merging this pull request may close these issues.

2 participants