Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace navigation via mouse back/forward buttons #2771

Conversation

kristijanribaric
Copy link
Contributor

Adds the ability to navigate workspaces using the mouse back/forward buttons when hovering over the sidebar. This improves the user experience by providing a more intuitive way to switch between workspaces.

This feature is only enabled when workspaces are enabled. It intercepts the "AppCommand" events to handle back/forward navigation.

Adds the ability to navigate workspaces using the mouse
back/forward buttons when hovering over the sidebar.  This
improves the user experience by providing a more intuitive
way to switch between workspaces.

This feature is only enabled when workspaces are enabled.
It intercepts the "AppCommand" events to handle back/forward
navigation.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Feature labels Nov 9, 2024
Removed a debug `console.log` statement that was used
during swipe gesture implementation.  This is no
longer needed.
@mr-cheff mr-cheff merged commit e2e46d6 into zen-browser:dev Nov 9, 2024
1 check passed
@olerap
Copy link

olerap commented Nov 11, 2024

Was very excited when I saw this feature being added, unfortunately not working for me right now on macOS. Using a Logitech Master 3S, forward/backward buttons are set to default. Apart from this feature they function as expected.

@kristijanribaric
Copy link
Contributor Author

Hm that's interesting.
Can you check in about:config page if you have preferences mousebutton.4th.enabled and mousebutton.5th.enabled set to true?

Just to be sure, you are pressing forward/backward buttons while hovering the sidebar, right?

Also, can you confirm that the page goes forward/backward in history when pressing those buttons while hovering the page content?

@olerap
Copy link

olerap commented Nov 11, 2024

Yes, these are enabled and yes, I hover over the bar while doing so. Weird thing is, when I use a "swipe" gesture using two fingers on my Mac's touchpad is does work.

@kristijanribaric
Copy link
Contributor Author

The swipe gesture is not related to this as it uses a different logic for detecting workspace switching.

You didn't confirm that forward/backward buttons when hovering the page content navigate the tab history back or forward.

@olerap
Copy link

olerap commented Nov 11, 2024

Hereby confirmed, this does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants