Feature: Workspace-specific bookmarks #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
…for storing relationships between workspaces and bookmarks.
kristijanribaric
force-pushed
the
feature/workspace-specific-bookmarks
branch
from
ba2bc4a to
7b976c3
Compare
Updates the Edit Bookmark dialog to use the new Zen color variables for the dropdown and suggestion list backgrounds. This ensures consistency with the overall Zen theme and improves visual appeal. Specifically, the `--in-content-box-background` variable is replaced with `--zen-colors-tertiary` for the affected elements. Additionally, padding in the suggestion list and its items has been slightly adjusted for better spacing.
|
@kristijanribaric, how will this work with Firefox bookmark sync? I am not a contributor just curious. |
Renames the internal cache variable `_bookmarkWorkspaceCache` to `_workspaceBookmarksCache` for consistency and clarity. This change does not affect functionality.
The workspace selection summary in the bookmark editor now displays a comma-separated list of selected workspace names instead of just the number of selected workspaces. This improves the user experience by providing more context and clarity about which workspaces the bookmark will be associated with. Previously, the summary only showed "N workspaces selected". This change makes it easier to see at a glance which workspaces are selected without having to open the dropdown.The change also ensures the initial display of the summary text correctly reflects the selected workspaces when the editor opens.
It will need a new sync engine or I'll be able to integrate it in a workspace sync engine. Either way it's totally doable. |
Improves the styling of the folder picker dropdown in the edit bookmark panel to align with Photon Design System guidelines: * Sets dropdown to take full width of the panel. * Changes dropdown's `top` positioning to be directly below the input field. * Updates border and outline styling for better visibility and focus indication. * Adds a subtle box-shadow for visual separation. These changes enhance the visual consistency and usability of the folder picker.
|
Thanks! Let's test it out in twilight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added workspace selector on bookmarks create/edit modal, added table for storing relationships between workspaces and bookmarks.
Recording.2024-11-26.224342.mp4