-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restricted scrolling beyond the first and last workspaces and fixed bug with Sidebar Switches Multiple Spaces Instead of One #3217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting twice Signed-off-by: Studio Movie Girl <[email protected]>
ngl i have no idea what to call this thing Signed-off-by: Studio Movie Girl <[email protected]>
Signed-off-by: Studio Movie Girl <[email protected]>
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
Bug
labels
Nov 26, 2024
Signed-off-by: Studio Movie Girl <[email protected]>
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Nov 27, 2024
Signed-off-by: Studio Movie Girl <[email protected]>
Signed-off-by: Studio Movie Girl <[email protected]>
kristijanribaric
suggested changes
Nov 27, 2024
Ready for merge? @neurokitti |
Should be. I haven't been able to test the prefs because my zen install is still having the patch issue |
I'm going to do more testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed this bug #3162
I made is to that if you keep swiping at the end of a workspace it no longer just wraps around.
IMPORTANT:
ive added some code for scrolling through workspaces with the scroll wheel and a modifer key but my zen install is having issues and i cant run a full build to test if the changes work because this patch. i checked and it has nothing to do with this PR but this feature deffinatly needs to be tested lol