Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication of node version for ease of maintenance #3283

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

vraravam
Copy link
Contributor

Node version can now be maintained in the .nvmrc file alone. GHA workflows will reuse from that file for ease of maintenance

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Improvement labels Nov 28, 2024
@vraravam
Copy link
Contributor Author

vraravam commented Dec 1, 2024

Thanks for the great browser!

Just wondering if there's anything blocking this PR from getting merged? If there's something I can do to help out or speed it along I'm willing to contribute.

@mauro-balades mauro-balades merged commit 4f8cd7f into zen-browser:dev Dec 1, 2024
1 check passed
@mauro-balades
Copy link
Member

Thanks!

@vraravam vraravam deleted the remove-duplication branch December 2, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants