Projectiles #371

ampersand38 · 2020-05-07T22:34:55Z

When merged this pull request will:

Add modules to have AI throw grenades, fire GL, and fire launcher, on high or low ballistic trajectory
https://youtu.be/XNVXETJFnHQ
https://www.youtube.com/watch?v=zLU1RAM9rao

BrettMayson · 2020-05-07T22:41:59Z

Is it possible to predict the arc? I am not a fan of the module for switching between high / flat. It would be nice to have an approximate arc, and use a keybind to switch modes while placing the target.

addons/modules/XEH_PREP.hpp

addons/modules/CfgVehicles.hpp

addons/modules/functions/fnc_moduleThrowSmoke.sqf

addons/modules/functions/fnc_projectiles_unit.sqf

jonpas · 2020-05-07T22:52:10Z

How does one select a grenade that's not part of that selection? Eg. some mod adds a dart (just a random thing I came up with right now), with this implementation of multiple modules, can one do that?

That arc doesn't really seem to be an arc, it's just a straight line? I don't really see the reason for that as a module, could be a CBA Setting for those scenarios where Zeus needs to be limited or someone can't handle line drawing performance. No need to clutter the modules.

BrettMayson · 2020-05-07T22:56:03Z

How does one select a grenade that's not part of that selection?

A module for just throwing that gets all the throwables would be better, could be done with BIS_fnc_isThrowable

ampersand38 · 2020-05-07T23:33:51Z

Is it possible to predict the arc? I am not a fan of the module for switching between high / flat. It would be nice to have an approximate arc, and use a keybind to switch modes while placing the target.

It's using the initSpeed and calculating the launch angle such that the ballistic arc hits the targetPos. There's always 2 possible arcs.

ampersand38 · 2020-05-07T23:42:25Z

That arc doesn't really seem to be an arc, it's just a straight line? I don't really see the reason for that as a module, could be a CBA Setting for those scenarios where Zeus needs to be limited or someone can't handle line drawing performance. No need to clutter the modules.

High Arc would be needed for hitting a roof top, or over a wall, for example.

ampersand38 · 2020-05-08T00:17:57Z

How does one select a grenade that's not part of that selection?

A module for just throwing that gets all the throwables would be better, could be done with BIS_fnc_isThrowable

That would be a useful feature. I've worked on the standard stuff because it's faster to not have to choose a throwable.

jonpas · 2020-05-08T00:33:13Z

What about using ZENs context menu? Select AI, right click at location to throw. Clicking "Throw" would throw something based on some priority (or just first available), sub-menu for manual selection.

Same for "Launch", launcher or GL.

ampersand38 · 2020-05-08T02:06:54Z

What about using ZENs context menu? Select AI, right click at location to throw. Clicking "Throw" would throw something based on some priority (or just first available), sub-menu for manual selection.

Same for "Launch", launcher or GL.

~~Is it currently possible to open context menu with AI selected? The default right click of course sets a waypoint.~~ Oh I see, using _hoveredEntity.

Are grenade commands used frequently enough to deserve a spot on every unit's context menu?

bux · 2020-05-08T04:32:32Z

Are grenade commands used frequently enough to deserve a spot on every unit's context menu?

imho, no

ampersand38 · 2020-05-08T04:37:01Z

Latest Throw Select module lists unit's available throwables in context menu between dropping the module and selecting target position.

~~I haven't worked out how to remove the actions if menu is closed without choosing one of the~~ throwables. https://youtu.be/HItqwS8pbkk
~~Is there an event for closing the menu?~~

Same for "Launch", launcher or GL.

These have additional complication of loading the chosen round, if we're not just shooting whatever is loaded.

If there's no demand for being able to throw frag/stone/smoke regardless of actual availability, I can cut down the modules to:

ThrowSelect
GL
Launcher
Trajectory

bux · 2020-05-08T04:54:55Z

Are grenade commands used frequently enough to deserve a spot on every unit's context menu?

Possible way to fix this could be the following idea, that is - of course - not in scope of this PR.
Use keyboard modifiers to open different context menus:

Hold down Alt and right click to get the offensive targeted context menu actions like throwing grenades or a quick access to a "search and destroy" waypoint
Hold down Shift while right clicking to get the more defensive targeted context menu actions. ....
etc ...

I don't know if that's possible at all, maybe that's an idea @mharis001 could use.

Such modifiers to open different context menus are already used in different graphic software. So it's not something completely uncommon 😄

CreepPork · 2020-05-08T16:54:02Z

I would let you know a similar feature is in development too: #132

ampersand38 · 2020-05-08T18:16:02Z

spawn and waitUntil have been CBA-ized.
Throw selected grenade is working properly.
Fire Launcher is more reliable.
https://www.youtube.com/watch?v=zLU1RAM9rao

mharis001 · 2020-05-12T04:17:44Z

I dislike the addition of this many modules. I think it can be limited to Fire Launcher, Fire GL, and Throw Grenade. Modules that require ALiVE should be removed. Also, the various actions do not work if the unit is in combat.

The current implementation into the context menu is pretty rough. If we want to keep that, it would be better to have only grenade actions shown. That requires a small change to context_menu which would allow entirely different action trees to be used when opening the menu - something I was planning on doing eventually for #132 .

For what @bux suggested, cba_events_shift and cba_events_alt can be used for the action conditions to achieve that.

ampersand38 · 2020-05-12T15:40:42Z

I've removed and renamed the extraneous modules. I've noticed that throw commands sent while units are in certain actions (reloading, sprinting, or suppressing) will be delayed or ignored, but most are executed. https://youtu.be/xOgiUzg8214

ampersand38 · 2020-05-14T17:33:57Z

Added icons https://steamuserimages-a.akamaihd.net/ugc/1026203216031872831/AF6C7BF14D3E4929B38548A265ED14D64A02DA35/

Kexanone · 2020-05-23T02:58:02Z

I really like these features. I considered getting launchers working for AI as impossible for some while. It works as good as it can considering how hard it is getting alerted ArmA AI to do what you want them to do. However, I have a few comments:

Did you try getting missile launchers working? There apparently is a setMissileTarget command. I have never used it so far tbh.
It seems that I somehow managed to break the modules when I used them a lot. Unfortunately, I haven't figured it out how to reproduce it. When it is broken, the module is always executed for the same unit, no matter on which unit I place the module.
Throw select: It would be better to get rid of all the other context menu entries that are unrelated to the module.

Kexanone · 2020-05-24T13:20:24Z

I'm curious about your formula for calculating the initial angle. Do you have a reference or derivation for it?

ampersand38 · 2020-05-26T17:45:24Z

I'm curious about your formula for calculating the initial angle. Do you have a reference or derivation for it?

I got it from this video https://www.youtube.com/watch?v=bqYtNrhdDAY

ampersand38 · 2020-06-26T17:10:58Z

Now working with soft launch weapons (RPG, NLAW, Titan, Vorona) https://youtu.be/gSjC2l98-Ps

Choose from unit's available throwables in context menu. Issue: actions not removed if context menu is closed.

Repalced spawn and waitUntil with CBA Use AnimChanged EH to re-fire launcher as needed Added comments and test code

This reverts commit 07aefb1.

CreepPork · 2021-03-04T08:54:00Z

For the grenades a graphical drawing like ACE's advanced throwing would be excellent for this.

mharis001 added the feature Adds a new feature label May 7, 2020

mharis001 added this to the 1.8.0 milestone May 7, 2020

BrettMayson reviewed May 7, 2020

View reviewed changes

mharis001 modified the milestones: 1.8.0, 1.9.0 May 19, 2020

ampersand38 force-pushed the projectiles branch from 24f5c2a to 07aefb1 Compare June 8, 2020 16:35

CreepPork mentioned this pull request Jul 23, 2020

Add Throw Grenade context menu action #132

Merged

mharis001 modified the milestones: 1.9.0, 1.10.0 Aug 10, 2020

Added Projectiles modules

b6eae57

ampersand38 added 18 commits August 31, 2020 11:38

Add module for Throw Select

7ebd6a5

Choose from unit's available throwables in context menu. Issue: actions not removed if context menu is closed.

Reliability and performance

093fb91

Repalced spawn and waitUntil with CBA Use AnimChanged EH to re-fire launcher as needed Added comments and test code

Corrected example code

5692c7b

Separate ballistics function

44b69dc

Name fix

117923e

Clear grenade actions on context menu close

fb5d8b8

Removed and renamed movdules

cd243ff

Tabs to spaces

7ab17fa

Tabs to spaces

90bda12

Nicer Icons

eb9dd68

Update config.cpp

139dd9a

Revert "Update config.cpp"

76120e6

This reverts commit 07aefb1.

Authors

296f069

add return

78f397b

Soft launch

a4d9a18

Don't run if position selection is cancelled

622fc7e

if condition parens

669c713

Module List documentation

1185850

ampersand38 force-pushed the projectiles branch from d11733d to 1185850 Compare August 31, 2020 15:39

zen_context_menu_fnc_open

1318549

mharis001 modified the milestones: 1.10.0, 1.11.0 Feb 3, 2021

mharis001 modified the milestones: 1.11.0, 1.12.0 May 25, 2021

Merge branch 'master' into projectiles

27abc1d

mharis001 modified the milestones: 1.12.0, 1.13.0 Sep 3, 2021

mharis001 modified the milestones: 1.13.0, Backlog Apr 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Projectiles #371

Projectiles #371

ampersand38 commented May 7, 2020 •

edited

Loading

BrettMayson commented May 7, 2020

jonpas commented May 7, 2020

BrettMayson commented May 7, 2020

ampersand38 commented May 7, 2020 •

edited

Loading

ampersand38 commented May 7, 2020 •

edited

Loading

ampersand38 commented May 8, 2020

jonpas commented May 8, 2020 •

edited

Loading

ampersand38 commented May 8, 2020 •

edited

Loading

bux commented May 8, 2020

ampersand38 commented May 8, 2020 •

edited

Loading

bux commented May 8, 2020

CreepPork commented May 8, 2020

ampersand38 commented May 8, 2020 •

edited

Loading

mharis001 commented May 12, 2020

ampersand38 commented May 12, 2020 •

edited

Loading

ampersand38 commented May 14, 2020

Kexanone commented May 23, 2020 •

edited

Loading

Kexanone commented May 24, 2020

ampersand38 commented May 26, 2020

ampersand38 commented Jun 26, 2020

CreepPork commented Mar 4, 2021

Projectiles #371

Are you sure you want to change the base?

Projectiles #371

Conversation

ampersand38 commented May 7, 2020 • edited Loading

BrettMayson commented May 7, 2020

jonpas commented May 7, 2020

BrettMayson commented May 7, 2020

ampersand38 commented May 7, 2020 • edited Loading

ampersand38 commented May 7, 2020 • edited Loading

ampersand38 commented May 8, 2020

jonpas commented May 8, 2020 • edited Loading

ampersand38 commented May 8, 2020 • edited Loading

bux commented May 8, 2020

ampersand38 commented May 8, 2020 • edited Loading

bux commented May 8, 2020

CreepPork commented May 8, 2020

ampersand38 commented May 8, 2020 • edited Loading

mharis001 commented May 12, 2020

ampersand38 commented May 12, 2020 • edited Loading

ampersand38 commented May 14, 2020

Kexanone commented May 23, 2020 • edited Loading

Kexanone commented May 24, 2020

ampersand38 commented May 26, 2020

ampersand38 commented Jun 26, 2020

CreepPork commented Mar 4, 2021

ampersand38 commented May 7, 2020 •

edited

Loading

ampersand38 commented May 7, 2020 •

edited

Loading

ampersand38 commented May 7, 2020 •

edited

Loading

jonpas commented May 8, 2020 •

edited

Loading

ampersand38 commented May 8, 2020 •

edited

Loading

ampersand38 commented May 8, 2020 •

edited

Loading

ampersand38 commented May 8, 2020 •

edited

Loading

ampersand38 commented May 12, 2020 •

edited

Loading

Kexanone commented May 23, 2020 •

edited

Loading