Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite how the UI performs updates #570

Merged
merged 14 commits into from
Nov 8, 2024
Merged

Conversation

zenangst
Copy link
Owner

@zenangst zenangst commented Nov 8, 2024

The way we handled updates from SwiftUI to logic was through closures. However, the view hierarchy made this incredibly challenging to work with. To address this, we now perform updates via a ConfigurationUpdater that is passed down as an environment object. Internally, this component can perform targeted updates to the current configuration, such as updating a workflow, a group, a trigger, or any other relevant component. Additionally, it debounces updates to the storage to prevent excessive disk writes.

Furthermore, the implementation includes significant renaming and organization of the UI components into different folders. Moreover, it employs more precise naming conventions to enhance clarity and maintainability.

Commit summary

  • Initial feature commit
  • Send configuration updates to configuration store Migrate workflow info to the new solution
  • Migrate WorkflowKeyboardTriggerView to use ConfigurationUpdater
  • Migrate workflow application trigger views to use configuration updater
  • Migrrate snippet trigger list
  • Finish up migrating workflow triggers
  • Remove old actions
  • Finish up updater migration for all detail views
  • Improve how updates are applied to the UI using the configuration updater
  • Fix UX when adding a new group (The group should be selected after creation)
  • Show keyboard shortcut in empty command list Fix dev tag
  • Various fixes of the initial load
  • Update release notes title
  • Rename and organize UI into proper folders

@zenangst zenangst merged commit 960e655 into main Nov 8, 2024
1 check failed
@zenangst zenangst deleted the feature/configuration-updater branch November 8, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant