Contribflow bullet-proofing and code cleanup #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(not found, service unavailable and timeout) Also cleaned up the files in lib and test for JSHint. Added files in bin for JSHint coverage. Testing: Grunt runs the tests now :) Manual testing: Create and delete a feature branch. Tested submitting against the video-js-swf repo, which still returns a 404 (but contribflow now returns a message to the user that they should try to submit the PR manually). Submitting this branch as a pull request will be a test of that part of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribflow bullet-proofing and code cleanup - got the tests running, fixed all the JSHint errors, and added a user message when HTTP error codes are returned by Github.
Fixes #17 and #18