Skip to content

Commit

Permalink
Merge pull request #22 from futuresimple/efedasz/support-gone-status
Browse files Browse the repository at this point in the history
Add support for http 410 status code
  • Loading branch information
Erwin Fedasz authored Jul 16, 2019
2 parents a100e98 + a7d8dc9 commit 118787b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/api_client/connection/basic.rb
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ def handle_response(request, response)
raise ApiClient::Errors::Unsupported.new(nil, request, response)
when 409
raise ApiClient::Errors::Conflict.new(nil, request, response)
when 410
raise ApiClient::Errors::Gone.new(nil, request, response)
when 422
raise ApiClient::Errors::UnprocessableEntity.new(response.body, request, response)
when 429
Expand Down
1 change: 1 addition & 0 deletions lib/api_client/errors.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class Redirect < ApiClientError; end
class BadRequest < ApiClientError; end
class Unsupported < ApiClientError; end
class Conflict < ApiClientError; end
class Gone < ApiClientError; end
class ServerError < ApiClientError; end
class UnprocessableEntity < ApiClientError; end
class TooManyRequests < ApiClientError; end
Expand Down
7 changes: 7 additions & 0 deletions spec/api_client/connection/basic_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,13 @@
}.should raise_error(ApiClient::Errors::Conflict, "Status code: 409")
end

it "raises an ApiClient::Errors::Gone if status is 410" do
@response.env[:status] = 410
lambda {
@instance.send :handle_response, request, @response
}.should raise_error(ApiClient::Errors::Gone, "Status code: 410")
end

it "raises an ApiClient::Errors::Unsupported if status is 422" do
@response.env[:status] = 422
lambda {
Expand Down

0 comments on commit 118787b

Please sign in to comment.