Bump Rails from 6.1 to 7.0 #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves the warning: > /ruby/3.3.6/lib/ruby/gems/3.3.0/gems/activesupport-7.0.8.6/lib/active_support/notifications/fanout.rb:3: > warning: /ruby/3.3.6/lib/ruby/3.3.0/mutex_m.rb was loaded from the standard library, but will no longer > be part of the default gems starting from Ruby 3.4.0.> You can add mutex_m to your Gemfile or gemspec > to silence this warning.
|
looks good, not many tests left 🤞 |
orien
force-pushed
the
rails-7.0
branch
2 times, most recently
from
8c91efa to
27792ae
Compare
|
I've taken this for a basic test drive in the Envato staging environment and all looks good. |
grosser
approved these changes
Jan 26, 2025
app/models/git_repository.rb
Outdated
Comment on lines
190
to
191
| Tempfile.create('git-stderr') do |error_file| | ||
| success, output = Samson::CommandExecutor.execute( |
There was a problem hiding this comment.
This PR is targeting your grosser/7 branch. Hence, this is including commits from master in the merge.
Alternatively, I could change it to target the master branch. This would include commits from #4120. Would you prefer this option?
There was a problem hiding this comment.
🤔 I think the alternative option would be less confusing. Updated.
| config.action_mailer.perform_caching = false | ||
|
|
||
| default_url_options[:port] = config.samson.uri.port | ||
|
|
||
| # Raise an error on page load if there are pending migrations | ||
| # Print deprecation notices to the Rails logger. | ||
| config.active_support.deprecation = :log |
There was a problem hiding this comment.
would love this to be raise so upgrades are smoother ... but can be later
|
I think it's good to go 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending #4120 with more fixes:
mutex_m, an undeclaredactivesupportdependency.csv, required for Ruby 3.4: this resolves a warning produced when running on Ruby 3.3.rails app:updateto merge in new configuration