Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use SleepAction for prestop hooks instead of ExecAction #4126

Merged
merged 1 commit into from
Jan 26, 2025
Merged

feat: use SleepAction for prestop hooks instead of ExecAction #4126

merged 1 commit into from
Jan 26, 2025

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Jan 23, 2025

Note: Samson is a public repo, do not include Zendesk-internal information, urls, etc.

⚠️ this is a breaking change for clusters on old version

References

  • Jira link:

Risks

  • Low: will break deployments for clusters older than 1.30

@a7i a7i requested a review from a team as a code owner January 23, 2025 16:34
@a7i a7i force-pushed the amir/prestop-sleep-action branch from f2efeb4 to b497f5c Compare January 23, 2025 16:56
@grosser grosser merged commit 19f070d into master Jan 26, 2025
8 of 9 checks passed
@grosser grosser deleted the amir/prestop-sleep-action branch January 26, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grosser grosser grosser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a7i @grosser