Add support for Rails 7.1 #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itskingori
commented
Oct 28, 2023
| @@ -1 +1 @@ | |||
| 2.7.8 | |||
| 3.2.2 | |||
There was a problem hiding this comment.
Not strictly necessary but I was unable to bundle with the Ruby version set ...
stronger_parameters/.ruby-version
Line 1 in 589cc2e
This is the error I was getting ...
Bundler could not find compatible versions for gem "minitest":
In snapshot (rails7.1.gemfile.lock):
minitest (= 5.20.0)
In rails7.1.gemfile:
maxitest was resolved to 0.0.1, which depends on
minitest (~> 5.4.2)
minitest-rails was resolved to 7.1.0, which depends on
minitest (~> 5.20)
Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.
Problem goes away when I used a 3.2.2. Figured since we're testing for it then it's ok? 🤷🏽♂️
There was a problem hiding this comment.
might run into trouble with bundle_all task ... but let's see
| @@ -1,4 +1,4 @@ | |||
| # frozen_string_literal: true | |||
| module StrongerParameters | |||
| VERSION = '2.21.1' | |||
| VERSION = '2.22.0' | |||
There was a problem hiding this comment.
I wasn't sure if I should be the one doing the bump or I should focus on the feature and let the maintainers bump.
There was a problem hiding this comment.
usually no, but does not matter much
|
needs a bundle_all |
|
trying here #119 |
|
v2.22.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can use this amazing gem with Rails 7.1 as well. There was an earlier attempt at it in #117 but it was blocked on
minitest-rails7.1.0 being released.Motivations
Related