Test without forking_test_runner #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plain tests run in ~1 second on my machine, as opposed to ~3 seconds before. The forking_test_runner gem was introduced in fa0ea22 with the message "forking runner for better converage". Curiously, the Singlecov numbers didn't change in that commit, and I don't know how coverage would be affected. Of course, running each test in its own fork avoid pollution between tests. I don't think that is an issue here, mainly because it wasn't mentioned when the gem was added.
|
it helps with
... so prefer keeping it or looking into parallel execution/preloading helper |
I actually enjoy that kind of test failures. Sometimes it’s an indication of some weird underlying issue (e.g. global variables / class instance variables) which could point to a potential problem with threading etc.
Coverage should probably only be calculated on CI anyway 😅 |
The idea of single_cov is that it should not be, you add code without test -> local/fast failure with "line 14 is not covered" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain tests run in ~1 second on my machine, as opposed to ~3 seconds before. The forking_test_runner gem was introduced in fa0ea22 with the message “forking runner for better converage.” Curiously, the Singlecov numbers didn't change in that commit, and I don't know how coverage would be affected.
Of course, running each test in its own fork avoid pollution between tests. I don't think that is an issue here, mainly because it wasn't mentioned when the gem was added.