[APPS-6948] Add manifest validation to deprecate password type param #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aishkan
force-pushed
the
aishkan/deprecate-password-param
branch
from
72500b7 to
d72b179
Compare
aishkan
changed the title
hansol-kim-zendesk
approved these changes
Aug 26, 2024
| @@ -22,7 +22,7 @@ def call(package) | |||
| return [ValidationError.new(:missing_manifest)] | |||
| end | |||
|
|
|||
| collate_manifest_errors(package) | |||
| collate_manifest_errors(package, opts.fetch(:skip_password_parameter_check, true) ) | |||
There was a problem hiding this comment.
Maybe I've been a manager too long, but I'm finding this a bit hard to follow. We default the skip_password_parameter value to false here, then default it to true here then apply the rule conditionally with a double negative.
Would it be simpler to change the variable name to apply_parameter_check and just give it the appropriate default value in one place?
There was a problem hiding this comment.
yeah that would be more readable. I have updated it now.
There was a problem hiding this comment.
Could we get the PR description updated with the new implementation using apply_parameter_check please?
aishkan
force-pushed
the
aishkan/deprecate-password-param
branch
3 times, most recently
from
b99ed3f to
989c20c
Compare
JeanMarcGoepfert
approved these changes
Aug 28, 2024
mmassaki
reviewed
Sep 10, 2024
aishkan
force-pushed
the
aishkan/deprecate-password-param
branch
from
989c20c to
6df7579
Compare
mmassaki
reviewed
Sep 16, 2024
aishkan
force-pushed
the
aishkan/deprecate-password-param
branch
from
6df7579 to
1a3fcad
Compare
|
This moved to #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💐
/cc @zendesk/wattle
Description
Add manifest validation to disallow password type params.
The check is based on enabling
skip_password_parameter_checkto ensure this validation works only for new app submission. The value will be passed in from Apps approval and ZAM.The skip_password_parameter_check value will be passed in from Apps Approval gem here.
References
https://zendesk.atlassian.net/browse/APPS-6946
Risks