Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

[BC Break] Remove annotations support for 4.0 #153

Merged
merged 6 commits into from
Apr 16, 2018
Merged

[BC Break] Remove annotations support for 4.0 #153

merged 6 commits into from
Apr 16, 2018

Conversation

lisachenko
Copy link
Contributor

@lisachenko lisachenko commented Apr 10, 2018 •
edited
Loading

This PR removes annotations API for 4.0 as proposed by @Ocramius in #32
Also removed the zendframework/zend-eventmanager dependency.

  • Remove all annotation API from classes
  • Remove all annotation related classes and tests from the library
  • Remove zendframework/zend-eventmanager dependency
  • Rebase on develop branch
  • Regenerate composer.lock file
  • Document changes in the CHANGELOG.md
  • Investigate build failure in the test https://travis-ci.org/zendframework/zend-code/jobs/364674886

Ocramius
Ocramius approved these changes Apr 10, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good improvement, but still needs documenting changes in CHANGELOG.md (specifically breaking changes).

@Ocramius Ocramius added this to the 4.0.0 milestone Apr 10, 2018
@Ocramius
Copy link
Member

@lisachenko since this patch targets the next release, it should be based off develop

@lisachenko lisachenko changed the title [BC Break] Remove annotations support for 4.0 [WIP][BC Break] Remove annotations support for 4.0 Apr 10, 2018
@lisachenko
Copy link
Contributor Author

Added several tasks into the check list

@lisachenko
Copy link
Contributor Author

lisachenko commented Apr 11, 2018 •
edited
Loading

BTW, should we define a 3.x from the develop branch and push it only with deprecation notices for annotation API?

@Ocramius
Copy link
Member

Not really needed tbh, as the user-base for annotations in here is quite narrow (I know of this mostly because I never receive any bug reports about annotations ;-) )

@lisachenko lisachenko force-pushed the feature/remove-annotations-support branch from b280684 to 021b1c5 Compare April 13, 2018 13:55
@lisachenko lisachenko changed the base branch from master to develop April 13, 2018 13:56
@lisachenko lisachenko changed the title [WIP][BC Break] Remove annotations support for 4.0 [BC Break] Remove annotations support for 4.0 Apr 13, 2018
@lisachenko
Copy link
Contributor Author

Awaiting approval on this PR

@Ocramius Ocramius self-assigned this Apr 16, 2018
@Ocramius
Copy link
Member

@weierophinney if you are ok with this I'll start pushing for 4.x overall.

@weierophinney
Copy link
Member

@Ocramius Totally on board!

@Ocramius Ocramius merged commit d1a9e9d into zendframework:develop Apr 16, 2018
@Ocramius
Copy link
Member

Alright, I suppose I need to revive some patches here over the next weekend :P

@Ocramius Ocramius mentioned this pull request Apr 16, 2018
Closed
@lisachenko
Copy link
Contributor Author

Alright, I suppose I need to revive some patches here over the next weekend :P

Ok, let's proceed with strict types then and bump PHP version)

@lisachenko lisachenko deleted the feature/remove-annotations-support branch April 18, 2018 12:56
michalbundyra added a commit that referenced this pull request Dec 10, 2019
@michalbundyra
Follow up #153 - remove unneeded doctrine/annotations dependency
389f532 
As the whole annotation functionality has been removed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
BC Break enhancement
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lisachenko @Ocramius @weierophinney