Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make shell scripts executable #116

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Nov 28, 2023

A user in slack reported that some of the shell scripts used internally were not executable. This was causing problems, so this PR fixes that for all the shell scripts by making them all executable. (chmod +x ... for all of them).

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation
    accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting
    develop. If your branch wasn't based on develop read
    Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    change)
  • Other (add details above)

@strickvl strickvl added bug Something isn't working internal labels Nov 28, 2023
@strickvl strickvl requested review from safoinme and wjayesh November 28, 2023 12:10
@strickvl strickvl requested a review from fa9r November 29, 2023 12:18
@strickvl strickvl merged commit 7d165f4 into develop Nov 29, 2023
@strickvl strickvl deleted the bugfix/shell-scripts-become-executable branch November 29, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants