Add deprecation notice #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa9r
suggested changes
Jul 17, 2023
Co-authored-by: Felix Altenberger <[email protected]>
fa9r
approved these changes
Jul 17, 2023
Co-authored-by: Felix Altenberger <[email protected]>
fa9r
reviewed
Jul 17, 2023
README.md
Outdated
| @@ -1,3 +1,10 @@ | |||
| # IMPORTANT NOTE: THIS REPOSITORY IS GOING TO BE DEPRECATED AFTER 01/08/2023. | |||
| ***Please consider the impact it might have on your ongoing work and plan accordingly.*** | |||
There was a problem hiding this comment.
Actually what's the purpose of this sentence? I guess users are not installing / building upon those repositories anyways so the deprecation shouldn't break anything, it only means that the examples are outdated / no longer maintaned.
There was a problem hiding this comment.
Yes, it means that no maintenance and potentially not working code is here. Plus we will archive those, so they will get into a read-only state.
This sentence is more of a politeness - doesn't have to be a showstopper for any production work, but might get some tiny side-effects for Dev or Research.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
README.md