Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finetuning guide #3157

Merged
merged 27 commits into from
Nov 6, 2024
Merged

Finetuning guide #3157

merged 27 commits into from
Nov 6, 2024

Conversation

strickvl
Copy link
Contributor

Draft of documentation / guide around LLM finetuning.

Gitbook preview here.

Remaining work

@strickvl strickvl added documentation Improvements or additions to documentation internal To filter out internal PRs and issues labels Oct 30, 2024
@strickvl strickvl requested review from htahir1 and wjayesh October 30, 2024 17:36
Copy link
Contributor

coderabbitai bot commented Oct 30, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright i read it again. I think its great. But I have some feedback:

  • There are lots of lists in the text like "Here is a list: here is an explanation" -> Id format this with the first part being in bold "Here is a list: here is an explanation"
  • This is again a pet peeve but bullet points , should they begin with a capital or small letter?...
  • For me the chapter that sort of doesn't "fit" well into the guide is "Starter choices with fine-tuning". I'm not quite sure whether its the lack of link outs or the lack of code in there that makes it just feel like I have a lot of reading to do before I get to the action.. maybe there is a way to condense it into a visual element or maybe tell the story in a code-centric way? Or give more examples as to the choices available?
  • Finetuning with Accelerate doesn't point out that we have an integration with a decorator... that is what I expected here tbh
  • I expected a link from the new evaluation section to the old RAG evaluation section but I found only "Please note that the approach taken for these evaluations is similar to that used and showcased in the RAG guide." .. Maybe there is a way to pick up the story from there? What is actually different from what was said before? There might be a shortcut by making a link back
  • The deployment chapter is missing a code snippet from our VLLM deployer by @dudeperf3ct :-) Id love to get that in there, even if it isn't released yet.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Images automagically compressed by Calibre's image-actions

Compression reduced images by 48.2%, saving 55.42 KB.

Filename Before After Improvement Visual comparison
docs/book/.gitbook/assets/finetuning-pipeline.png 114.91 KB 59.49 KB -48.2% View diff

369 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

@strickvl strickvl requested a review from htahir1 November 5, 2024 16:34
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback:

  • Looks like a lot of files have been deleted - would it make sense to add redirects for these?
  • Other than that and the comments this looks SUPER amazing and solid. Great work!!!

@strickvl
Copy link
Contributor Author

strickvl commented Nov 6, 2024

@htahir1 the deleted files were actually duplicate docs which weren't linked anywhere, so no need to link. they weren't in our TOC to start with.

@strickvl strickvl requested a review from htahir1 November 6, 2024 12:43
Copy link
Contributor

@htahir1 htahir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! LGTM!

@strickvl strickvl merged commit fa11794 into develop Nov 6, 2024
9 checks passed
@strickvl strickvl deleted the doc/finetuning-guide branch November 6, 2024 13:15
strickvl added a commit that referenced this pull request Nov 6, 2024
* update toc

* add first section

* fix mermaid title

* updates

* update 100 loc

* add getting started page

* fix link

* drafts

* update docs

* update next steps

* update link

* add accelerate docs

* Optimised images with calibre/image-actions

* update lists + formatting

* update getting started section

* remove excesses

* add notes on using accelerate decorator

* add docs link

* improve docs following review feedback

* draft the intro section

* update TOC with rename

* add resources guide

* fix links

* Update docs/book/user-guide/llmops-guide/finetuning-llms/why-and-when-to-finetune-llms.md

Co-authored-by: Jayesh Sharma <[email protected]>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jayesh Sharma <[email protected]>
strickvl added a commit that referenced this pull request Nov 6, 2024
* Finetuning guide (#3157)

* update toc

* add first section

* fix mermaid title

* updates

* update 100 loc

* add getting started page

* fix link

* drafts

* update docs

* update next steps

* update link

* add accelerate docs

* Optimised images with calibre/image-actions

* update lists + formatting

* update getting started section

* remove excesses

* add notes on using accelerate decorator

* add docs link

* improve docs following review feedback

* draft the intro section

* update TOC with rename

* add resources guide

* fix links

* Update docs/book/user-guide/llmops-guide/finetuning-llms/why-and-when-to-finetune-llms.md

Co-authored-by: Jayesh Sharma <[email protected]>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jayesh Sharma <[email protected]>

* add missing section (#3172)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jayesh Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants