-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finetuning guide #3157
Finetuning guide #3157
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright i read it again. I think its great. But I have some feedback:
- There are lots of lists in the text like "Here is a list: here is an explanation" -> Id format this with the first part being in bold "Here is a list: here is an explanation"
- This is again a pet peeve but bullet points , should they begin with a capital or small letter?...
- For me the chapter that sort of doesn't "fit" well into the guide is "Starter choices with fine-tuning". I'm not quite sure whether its the lack of link outs or the lack of code in there that makes it just feel like I have a lot of reading to do before I get to the action.. maybe there is a way to condense it into a visual element or maybe tell the story in a code-centric way? Or give more examples as to the choices available?
- Finetuning with Accelerate doesn't point out that we have an integration with a decorator... that is what I expected here tbh
- I expected a link from the new evaluation section to the old RAG evaluation section but I found only "Please note that the approach taken for these evaluations is similar to that used and showcased in the RAG guide." .. Maybe there is a way to pick up the story from there? What is actually different from what was said before? There might be a shortcut by making a link back
- The deployment chapter is missing a code snippet from our VLLM deployer by @dudeperf3ct :-) Id love to get that in there, even if it isn't released yet.
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 48.2%, saving 55.42 KB.
369 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
… doc/finetuning-guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback:
- Looks like a lot of files have been deleted - would it make sense to add redirects for these?
- Other than that and the comments this looks SUPER amazing and solid. Great work!!!
docs/book/user-guide/llmops-guide/finetuning-llms/finetuning-llms.md
Outdated
Show resolved
Hide resolved
docs/book/user-guide/llmops-guide/finetuning-llms/why-and-when-to-finetune-llms.md
Show resolved
Hide resolved
docs/book/user-guide/llmops-guide/finetuning-llms/getting-started-with-finetuning.md
Outdated
Show resolved
Hide resolved
docs/book/user-guide/llmops-guide/finetuning-llms/getting-started-with-finetuning.md
Outdated
Show resolved
Hide resolved
docs/book/user-guide/llmops-guide/finetuning-llms/next-steps.md
Outdated
Show resolved
Hide resolved
@htahir1 the deleted files were actually duplicate docs which weren't linked anywhere, so no need to link. they weren't in our TOC to start with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! LGTM!
docs/book/user-guide/llmops-guide/finetuning-llms/why-and-when-to-finetune-llms.md
Outdated
Show resolved
Hide resolved
…-to-finetune-llms.md Co-authored-by: Jayesh Sharma <[email protected]>
* update toc * add first section * fix mermaid title * updates * update 100 loc * add getting started page * fix link * drafts * update docs * update next steps * update link * add accelerate docs * Optimised images with calibre/image-actions * update lists + formatting * update getting started section * remove excesses * add notes on using accelerate decorator * add docs link * improve docs following review feedback * draft the intro section * update TOC with rename * add resources guide * fix links * Update docs/book/user-guide/llmops-guide/finetuning-llms/why-and-when-to-finetune-llms.md Co-authored-by: Jayesh Sharma <[email protected]> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jayesh Sharma <[email protected]>
* Finetuning guide (#3157) * update toc * add first section * fix mermaid title * updates * update 100 loc * add getting started page * fix link * drafts * update docs * update next steps * update link * add accelerate docs * Optimised images with calibre/image-actions * update lists + formatting * update getting started section * remove excesses * add notes on using accelerate decorator * add docs link * improve docs following review feedback * draft the intro section * update TOC with rename * add resources guide * fix links * Update docs/book/user-guide/llmops-guide/finetuning-llms/why-and-when-to-finetune-llms.md Co-authored-by: Jayesh Sharma <[email protected]> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jayesh Sharma <[email protected]> * add missing section (#3172) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jayesh Sharma <[email protected]>
Draft of documentation / guide around LLM finetuning.
Gitbook preview here.
Remaining work