VertexAI `Model-Registry` & `Model-Deployer` #3161

safoinme · 2024-10-31T12:48:03Z

Describe changes

TODO

Polish docs.
Uploads project example to projects repo

Pre-requisites

Please ensure you have done the following:

I have read the CONTRIBUTING.md document.
If my change requires a change to docs, I have updated the documentation accordingly.
I have added tests to cover my changes.
I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Other (add details above)

- Update model source URI retrieval in VertexAIModelRegistry. - Enhance BaseModelDeployer to check and start inactive services. - Set default replica counts to 1 and sync to False in VertexBaseConfig. - Rename and update documentation for deployment service creation in VertexModelDeployer.

coderabbitai · 2024-10-31T12:48:11Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

htahir1

Left initial thoughts. Also should we add these to the 1-stack deployment of the GCP full stack endpoint?

docs/book/component-guide/model-deployers/vertex.md

docs/book/component-guide/model-registries/vertex.md

src/zenml/integrations/gcp/__init__.py

src/zenml/integrations/gcp/flavors/vertex_model_deployer_flavor.py

src/zenml/integrations/gcp/flavors/vertex_model_registry_flavor.py

src/zenml/integrations/gcp/services/vertex_deployment.py

src/zenml/integrations/gcp/model_registries/vertex_model_registry.py

src/zenml/integrations/gcp/model_deployers/vertex_model_deployer.py

…onsistency

github-actions · 2024-11-07T13:47:35Z

LLM Finetuning template updates in examples/llm_finetuning have been pushed.

github-actions · 2024-11-07T13:47:56Z

Classification template updates in examples/mlops_starter have been pushed.

review-notebook-app · 2024-11-07T13:48:02Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions · 2024-11-07T13:54:13Z

E2E template updates in examples/e2e have been pushed.

github-actions · 2024-11-07T13:57:27Z

NLP template updates in examples/e2e_nlp have been pushed.

github-actions · 2024-11-07T15:07:26Z

LLM Finetuning template updates in examples/llm_finetuning have been pushed.

github-actions · 2024-11-07T15:07:45Z

Classification template updates in examples/mlops_starter have been pushed.

github-actions · 2024-11-07T15:14:36Z

E2E template updates in examples/e2e have been pushed.

github-actions · 2024-11-07T15:17:28Z

NLP template updates in examples/e2e_nlp have been pushed.

gitguardian · 2024-11-08T20:12:03Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

stefannica · 2024-11-11T13:59:36Z

src/zenml/model_registries/base_model_registry.py

@@ -62,14 +63,24 @@ class ModelRegistryModelMetadata(BaseModel):
    model and its development process.
    """

-    zenml_version: Optional[str] = None
+    _managed_by: str = "zenml"


Neither this field nor its associated property are actually used anywhere. Is there something missing ?

It will return this as a set of key-value when ModelRegistryModelMetadata object is called

…rn materializer

github-actions · 2024-11-12T14:35:15Z

LLM Finetuning template updates in examples/llm_finetuning have been pushed.

safoinme and others added 16 commits June 3, 2024 12:58

initial commit on vertex ai deployer and model registry

2fb8a7d

vertex model

c03f2a0

Merge branch 'develop' into feature/vertex-ai-deployer-model-registry

3c6bbe9

vertex deployer

4eeeb27

Merge branch 'develop' into feature/vertex-ai-deployer-model-registry

7881b69

vertex registry code

7c0ca3f

format

6769b6c

Refactor model registration and add URI parameter

9a03f34

Refactor model registration and add URI parameter

afc5c2b

Refactor model registration and remove unnecessary code

2dc0d2d

Merge branch 'develop' into feature/vertex-ai-deployer-model-registry

5c5bb84

Refactor GCP service and flavor classes for Vertex AI deployment

54b6748

Merge branch 'develop' into feature/vertex-ai-deployer-model-registry

a80f71a

Merge branch 'develop' into feature/vertex-ai-deployer-model-registry

6e2b660

Refactor model deployer configurations and add VertexAI model deployer

0a13214

github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Oct 31, 2024

Refactor model deployer configurations and add VertexAI model deployer

53da68d

safoinme requested a review from strickvl October 31, 2024 12:50

htahir1 requested review from bcdurak and schustmi October 31, 2024 13:00

htahir1 requested changes Oct 31, 2024

View reviewed changes

schustmi requested changes Oct 31, 2024

View reviewed changes

safoinme requested review from stefannica and removed request for strickvl and bcdurak November 4, 2024 08:08

safoinme added 2 commits November 4, 2024 15:21

Merge branch 'develop' into feature/vertex-ai-deployer-model-registry

ff015e1

Rename VertexAI model registry classes and update documentation for c…

ce2019d

…onsistency

Auto-update of LLM Finetuning template

14f2998

Auto-update of Starter template

0b30a61

Auto-update of E2E template

83dfe31

actions-user and others added 3 commits November 7, 2024 13:57

Auto-update of NLP template

7888717

Merge branch 'develop' into feature/vertex-ai-deployer-model-registry

72cc93c

Auto-update of LLM Finetuning template

70cc4a9

safoinme requested review from schustmi and htahir1 November 7, 2024 15:07

Auto-update of Starter template

fcdec6e

Auto-update of E2E template

0108c0f

Auto-update of NLP template

0c33f82

Merge branch 'develop' into feature/vertex-ai-deployer-model-registry

4f18ba5

stefannica reviewed Nov 11, 2024

View reviewed changes

safoinme and others added 2 commits November 12, 2024 15:32

Update default filenames and improve backward compatibility for sklea…

012cd6e

…rn materializer

Auto-update of LLM Finetuning template

ac2e69a

safoinme requested a review from stefannica November 12, 2024 15:40

Merge branch 'develop' into feature/vertex-ai-deployer-model-registry

3d558ae

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VertexAI `Model-Registry` & `Model-Deployer` #3161

VertexAI `Model-Registry` & `Model-Deployer` #3161

safoinme commented Oct 31, 2024 •

edited

Loading

coderabbitai bot commented Oct 31, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

htahir1 left a comment

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

review-notebook-app bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

gitguardian bot commented Nov 8, 2024 •

edited

Loading

stefannica Nov 11, 2024

safoinme Nov 12, 2024

github-actions bot commented Nov 12, 2024

VertexAI Model-Registry & Model-Deployer #3161

Are you sure you want to change the base?

VertexAI Model-Registry & Model-Deployer #3161

Conversation

safoinme commented Oct 31, 2024 • edited Loading

Describe changes

TODO

Pre-requisites

Types of changes

coderabbitai bot commented Oct 31, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

htahir1 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

review-notebook-app bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

github-actions bot commented Nov 7, 2024

gitguardian bot commented Nov 8, 2024 • edited Loading

️✅ There are no secrets present in this pull request anymore.

stefannica Nov 11, 2024

Choose a reason for hiding this comment

safoinme Nov 12, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 12, 2024

VertexAI `Model-Registry` & `Model-Deployer` #3161

VertexAI `Model-Registry` & `Model-Deployer` #3161

safoinme commented Oct 31, 2024 •

edited

Loading

gitguardian bot commented Nov 8, 2024 •

edited

Loading