-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve source root docs/logs when running a pipeline #3357
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@stefannica I already added a log that tells users to check whether their source root is correct before uploading the code. Do you think we should have an additional warning that we print when the |
@strickvl I'm not sure if that might be too early and complicated on this page. It's not really relevant for local runs anyway, and even in remote runs from a single file it's not really necessary as it should work as expected. Especially given that the user probably hasn't used ZenML before, and therefore doesn't have any orphan |
Yeah I wasn't even thinking to go into that detail. Just to say something simple like "oh and do a |
@strickvl Added a small mention |
I think what you did should be enough. |
Describe changes
I implemented/fixed _ to achieve _.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes