-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add HTML expectation #23
base: 1.x
Are you sure you want to change the base?
Conversation
432a48e
to
3cba1cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 LGTM
for my information, what was the complexity of using these html expectations in zenstruck/browser. It feels like thos packages could be compatible
jobs: | ||
tests: | ||
uses: zenstruck/.github/.github/workflows/php-test.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have you decided to stop using the shared actions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
env variables aren't passed down to shared actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you need this behavior more than once, I'm pretty sure there is some hackto do to pass envs from workflow to external action
I actually have an alternative system I'm cooking up. Stay tuned :) |
I've created a new zenstruck/assert-html package which is like a plugin for this library to make html assertions.
I've extracted this code from zenstruck/browser and will create a followup PR there to utilize this new library.edit: doing this created more complexity than I liked. Additionally, this new package will allow zenstruck/mailer-test#1.Some notes:
TODO: