Make phpstan happy

zenstruck · Mar 3, 2023 · 70087e1 · 70087e1
1 parent 76bf8e2
commit 70087e1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -1,5 +1,6 @@
 parameters:
     level: 8
+    checkGenericClassInNonGenericObjectType: false
     treatPhpDocTypesAsCertain: false
     paths:
         - src

diff --git a/src/Filesystem/Symfony/HttpKernel/PendingFileValueResolverTrait.php b/src/Filesystem/Symfony/HttpKernel/PendingFileValueResolverTrait.php
@@ -14,6 +14,7 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadata;
 use Symfony\Component\HttpKernel\Exception\HttpException;
+use Symfony\Component\Validator\ConstraintViolationList;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 use Symfony\Contracts\Service\ServiceProviderInterface;
 use Zenstruck\Filesystem\Attribute\UploadedFile;
@@ -27,7 +28,6 @@
 trait PendingFileValueResolverTrait
 {
     public function __construct(
-        /** @var ServiceProviderInterface<RequestFilesExtractor> $locator */
         private ServiceProviderInterface $locator
     ) {
     }
@@ -41,9 +41,9 @@ public function resolve(Request $request, ArgumentMetadata $argument): iterable
 
         $files = $this->extractor()->extractFilesFromRequest(
             $request,
-            $attribute->path,
-            $attribute->multiple,
-            $attribute->image,
+            (string) $attribute->path,
+            (bool) $attribute->multiple,
+            (bool) $attribute->image,
         );
 
         if ($files && $attribute->constraints) {
@@ -53,7 +53,9 @@ public function resolve(Request $request, ArgumentMetadata $argument): iterable
             );
 
             if (\count($errors)) {
-                throw new HttpException($attribute->errorStatus, (string) $errors);
+                \assert($errors instanceof ConstraintViolationList);
+
+                throw new HttpException((int) $attribute->errorStatus, (string) $errors);
             }
         }