fix importance singularity

zenustech · Jan 15, 2025 · b4ed874 · b4ed874
1 parent f41ebeb
commit b4ed874
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/zenovis/xinxinoptix/LightBounds.cpp b/zenovis/xinxinoptix/LightBounds.cpp
@@ -44,7 +44,10 @@ float LightBounds::importance(Vector3f p, Vector3f n) const {
         return 0;
 
     // Return final importance at reference point
-    float importance = phi * cosThetap / d2;
+    //float importance = phi * cosThetap / d2;
+    float r2 = 1.0f; float d = sqrtf(d2);
+    float importance = phi * cosThetap * 2.0f / ( d  * sqrtf(d2 + r2) + d2 + r2 );
+
     DCHECK(importance >= -1e-3);
     // Account for $\cos\theta_\roman{i}$ in importance at surfaces
     if (n[0]!=0 && n[1]!=0 && n[2]!=0) {

diff --git a/zenovis/xinxinoptix/LightTree.h b/zenovis/xinxinoptix/LightTree.h
@@ -154,7 +154,10 @@ struct CompactLightBounds {
             return 0;
 
         // Return final importance at reference point
-        float importance = phi * cosThetap / d2;
+        //float importance = phi * cosThetap / d2;
+        float r2 = 1.0f; float d = sqrtf(d2);
+        float importance = phi * cosThetap * 2.0f / ( d  * sqrtf(d2 + r2) + d2 + r2 );
+
         DCHECK(importance >= -1e-3f);
 
         if (n[0]!=0 && n[1]!=0 && n[2]!=0) {