Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream/rx zephyr support pr1.1 #49

Merged

Conversation

duynguyenxa
Copy link
Member

@duynguyenxa duynguyenxa commented Nov 18, 2024

This PR is update for RX hal layer for Zephyr RX MCU porting. The support contains:

  • Basic support for Clock Initialization.
  • Hal layer driver support for GPIO, SCI UART

License of hal is now changed to BSD-3 Clause

@quytranpzz
Copy link
Contributor

quytranpzz commented Mar 5, 2025

force-push to:

  • rebase with the main branch
  • change the license to BSD-3 Clause

@quytranpzz quytranpzz force-pushed the upstream/rx_zephyr_support_PR1.1 branch 2 times, most recently from 1df0ef5 to 1312bcc Compare March 6, 2025 08:58
@duynguyenxa duynguyenxa marked this pull request as ready for review March 7, 2025 02:55
@KhiemNguyenT KhiemNguyenT self-requested a review March 12, 2025 09:22
Copy link
Collaborator

@KhiemNguyenT KhiemNguyenT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License is changed for OSS compliance. Look good to me.

@quytranpzz quytranpzz force-pushed the upstream/rx_zephyr_support_PR1.1 branch from 1312bcc to a40f3fc Compare March 20, 2025 11:10
# SPDX-License-Identifier: Apache-2.0

set(include_dirs
rdp_cfg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no rdp_cfg in drivers/rx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated it, thank you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. LGMT!

This is initial commit to support Renesas RX with RX driver package
(rdp)

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz quytranpzz force-pushed the upstream/rx_zephyr_support_PR1.1 branch from a40f3fc to f3dea73 Compare March 25, 2025 06:56
quytranpzz and others added 5 commits March 25, 2025 13:57
Initial commit to support GPIO drivers on RX130 mcu with r_gpio_rx
Renesas driver package (rdp)

Signed-off-by: Quy Tran <[email protected]>
Initial commit to support PINCTRL driver on RSK-RX130-512kb board using
r_mpc_rx with RDP

Signed-off-by: Quy Tran <[email protected]>
Initial commit to support serial driver on RSK-RX130-512kb with r_sci_rx
on RDP

Signed-off-by: Quy Tran <[email protected]>
Update CMakelists file to add mcu_locks.c for SOC early intialization

Signed-off-by: Keita Kashima <[email protected]>
- Add suppress warning in CMakeList for the missing braces
- Add the suffix f to fix the double promotion warning

Signed-off-by: Quy Tran <[email protected]>
@quytranpzz quytranpzz force-pushed the upstream/rx_zephyr_support_PR1.1 branch from f3dea73 to 2099ebe Compare March 25, 2025 06:59
@soburi
Copy link
Member

soburi commented Mar 26, 2025

It would be a good idea to attach the results of running scancode as evidence.

@quytranpzz
Copy link
Contributor

quytranpzz commented Mar 27, 2025

It would be a good idea to attach the results of running scancode as evidence.

@soburi : I attached the results of running scancode for this patch here, please take a look. Thank you
result_driver.json: for hal/renesas/drivers/rx/*
result_zephyr.json: for hal/renesas/zephyr/rx/*

@soburi
Copy link
Member

soburi commented Mar 27, 2025

It would be a good idea to attach the results of running scancode as evidence.

@soburi : I attached the results of running scancode for this patch here, please take a look. Thank you result_driver.json: for hal/renesas/drivers/rx/* result_zephyr.json: for hal/renesas/zephyr/rx/*

Thank you for addressing.
LGTM

@KhiemNguyenT KhiemNguyenT merged commit 6abab60 into zephyrproject-rtos:main Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants