Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: stm32wb0: Add BLE controller implementation #236

Merged
merged 3 commits into from
Nov 25, 2024
Merged

lib: stm32wb0: Add BLE controller implementation #236

merged 3 commits into from
Nov 25, 2024

Conversation

HoZHel
Copy link
Collaborator

@HoZHel HoZHel commented Oct 10, 2024

Provide BLE controller implementation for STM32WB0x SOCs.

Provide the required license (ST ULTIMATE LIBERTY) to use the binary BLOB.

Modify the yaml file to support fetching the STM32WB0 binary stack library
for Bluetooth implementation.

@HoZHel HoZHel mentioned this pull request Oct 10, 2024
Closed
2 tasks
erwango
erwango requested changes Oct 10, 2024
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A README file summing up the origin of the files added would be required.
Similar to https://github.com/zephyrproject-rtos/hal_stm32/blob/main/lib/stm32wb/hci/README.

Also, to simplify follow up maintenance, I'd expect these files could be updated automatically using existing script. This is not a blocker, but it would be required to have it eventually.

lib/CMakeLists.txt Show resolved Hide resolved
lib/stm32wb0/CMakeLists.txt Outdated Show resolved Hide resolved
@erwango erwango requested review from FRASTM and gautierg-st October 10, 2024 11:44
@HoZHel
Copy link
Collaborator Author

HoZHel commented Oct 11, 2024

A README file summing up the origin of the files added would be required. Similar to https://github.com/zephyrproject-rtos/hal_stm32/blob/main/lib/stm32wb/hci/README.

Ok, I'll add it.

Also, to simplify follow up maintenance, I'd expect these files could be updated automatically using existing script. This is not a blocker, but it would be required to have it eventually.

I will update this file in the future.

@HoZHel HoZHel mentioned this pull request Oct 11, 2024
Merged
@HoZHel
Copy link
Collaborator Author

HoZHel commented Oct 16, 2024

A README file summing up the origin of the files added would be required. Similar to https://github.com/zephyrproject-rtos/hal_stm32/blob/main/lib/stm32wb/hci/README.

Done.

erwango
erwango requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the CMake clean up.
So more comments on the files extracted from the lib to here. Are they all required ?

lib/stm32wb0/BLE_TransparentMode/Core/Src/stm32wb0x_hal_msp.c Show resolved Hide resolved
lib/stm32wb0/BLE_TransparentMode/Core/Src/main.c Outdated Show resolved Hide resolved
lib/stm32wb0/README Outdated Show resolved Hide resolved
erwango
erwango requested changes Oct 24, 2024
View reviewed changes
lib/stm32wb0/README Outdated Show resolved Hide resolved
erwango
erwango reviewed Oct 24, 2024
View reviewed changes
lib/stm32wb0/LICENSE.md Outdated Show resolved Hide resolved
erwango
erwango requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.
One minor change and we're good to go.

lib/stm32wb0/README Outdated Show resolved Hide resolved
@erwango erwango added the DNM label Nov 14, 2024
@HoZHel
zephyr: blobs: Provide the license for STM32WB0 BLOB
c8e3fa8 
Provide the required license (ST ULTIMATE LIBERTY) to use the binary BLOB.

Modify the yaml file to support fetching the STM32WB0 binary stack library
for Bluetooth implementation.

Signed-off-by: Ali Hozhabri <[email protected]>
@HoZHel
lib: stm32wb0: Add BLE controller implementation
9942083 
Provide BLE controller implementation for STM32WB0x SOCs.

Signed-off-by: Ali Hozhabri <[email protected]>
@HoZHel
lib: Add dedicated CMakeLists.txt for STM32WB and STM32WBA
ee68681 
Add dedicated CMakeLists.txt for STM32WB and STM32WBA to have consistency
with STM32WB0 approach.

Signed-off-by: Ali Hozhabri <[email protected]>
@HoZHel
Copy link
Collaborator Author

HoZHel commented Nov 22, 2024

Rebased
Removed trailing white spaces
dos2unix applied

@erwango erwango merged commit d5fb525 into zephyrproject-rtos:main Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwango erwango erwango approved these changes

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

Assignees
No one assigned
Labels
DNM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HoZHel @erwango