mspm0: Add MSPM0 support #51

msp-ti · 2024-02-03T19:19:12Z

Added MSPM0 DriverLib and header files to be used for MSPM0 devices.
Also includes mspm0 pinctrl dtsi file to add support for LP_MSPM0G3507.

vaishnavachath · 2024-02-07T08:08:57Z

@msp-ti , Thank you for your PR, can you confirm if these sources are auto generated from a TI SDK? if yes, is there a way for you to upgrade to newer versions in a automated/semi-automated manner as present for simplelink devices.

What would be the strategy for fixes from going to TI SDK in

Also are you adding support for MSPM0L series support as well, seeing a lot of files in the PR for those devices as well, are they intentionally added?

msp-ti · 2024-02-27T17:05:34Z

Hi @vaishnavachath, we could do an update of the SDK components quarterly, we may use a submodule based on the SDK that is uploaded to github.

msp-ti · 2024-02-28T22:08:30Z

Upon consideration and management, we may stick to updating these in a script. In a future revision, we can add this process of updating to the readme such that a user can patch the hal with a specific SDK or changes should that become necessary

fabiobaltieri · 2024-02-29T11:30:25Z

dts/ti/mspm0/mspm0g3507-pinctrl.dtsi

that's suspiciously specific, should/could be more generic? (the part number I mean)

So you would recommend not specifying the MSPM0G3507 part number in the commit message?

No I'm referring to the file name, maybe it should be matching to more parts in the family, like mspm0g3xxx or something

vaishnavachath · 2024-04-09T11:10:02Z

Hi @vaishnavachath, we could do an update of the SDK components quarterly, we may use a submodule based on the SDK that is uploaded to github.

@msp-ti Sounds good, it would be good to have a clear idea of this going forward as it will be difficult to fix this later. I don't have any other blocking comments.

JFMSP · 2024-04-16T20:22:48Z

I've generalized the way we're creating pinctrl, based on soc family and splitting additional pinctrl into components. The final SOC will have a pinctrl that should only be made up of previous pinctrls

fabiobaltieri · 2024-04-23T16:06:42Z

@JFMSP good job. Hey I see most files have a missing \n of EOF warning (GitHub marks them, the red thing at the end of the file). Could you check your editor and set it up to not do that and terminate the files correctly? Not having those causes extra noise in the diff when the file is updated.

jadonk · 2024-07-11T04:42:01Z

Hope this gets merged soon! cc @lorforlinux

vaishnavachath

Pending comments needs to be addressed.

Self: Testing after account reset : please ignore

vaishnavachath · 2024-11-04T16:27:47Z

README.rst

+Drivers and other improvements that are TI-specific will be updated periodically.
+These may change with new SDK releases as additional changes occur. 
+
+Please notify a TI Zephyr representative if additional changes are needed.


Not sure what the intent of this README is , if you want to add this , will recommend adding sections of the devices supported and the directory strtucture .etc for a top level overview.

This project is already listed as an entry here : https://github.com/zephyrproject-rtos/zephyr/blob/main/MAINTAINERS.yml#L4866

vaishnavachath · 2024-11-04T16:29:34Z

mspm0/CMakeLists.txt

@@ -0,0 +1,27 @@
+add_subdirectory(source/ti/devices)


Need a README under mspm0 directory detailing how these files were generated and how someone can update to a newer SDK , also please add details on what upstream SDK version these sources were generated, see
https://github.com/zephyrproject-rtos/hal_ti/blob/master/simplelink/README

vaishnavachath · 2024-11-04T16:32:30Z

Upon consideration and management, we may stick to updating these in a script. In a future revision, we can add this process of updating to the readme such that a user can patch the hal with a specific SDK or changes should that become necessary

@msp-ti @JFMSP , will recommend adding the information how these files were generated (/corresponding SDK) versions information in this PR itself.

vaishnavachath · 2024-11-04T16:34:53Z

@msp-ti @JFMSP can you please let us know what will be the process for carrying fixes to SDK, will you be picking the fixes from this repo to your SDK releases? See an example : #47

Quentis · 2024-11-09T05:50:05Z

@msp-ti @JFMSP When do you plan to add Zephyr support for MSPM0? Is it going to be released with Zephyr 4.0?

vaishnavachath · 2024-11-18T13:09:13Z

@JFMSP can you please look at the latest comments

parthitce

Thanks for your efforts. IMO it makes sense to split the whole changes in the 2 commits. One from the TI SDK/HAL and another specific to Zephyr (module.yml, CMake and so).

parthitce · 2024-11-28T04:22:01Z

LICENSE

@@ -0,0 +1,246 @@
+This file provides licensing information on the code provided in this repository.


Same license applies for simplelink as well?

parthitce · 2024-11-28T04:23:36Z

mspm0/CMakeLists.txt

@@ -0,0 +1,27 @@
+add_subdirectory(source/ti/devices)


parthitce · 2024-11-28T04:24:37Z

mspm0/CMakeLists.txt

+  zephyr_library_sources(
+	source/ti/driverlib/dl_uart.c
+	source/ti/driverlib/dl_common.c
+	source/ti/driverlib/dl_i2c.c


We don't have i2c in the zephyr PR. Should we rather limit this CMake specific to the ones already part of zephyr PR?

I think it'd be better to generalize to exposing the whole SDK with a glob (done below)

NACK! See below for comment

Added MSPM0 DriverLib and header files to be used for MSPM0 devices. Signed-off-by: Jackson Farley <[email protected]>

parthitce · 2024-12-10T09:11:34Z

mspm0/CMakeLists.txt

+	source/ti/driverlib/m0p/sysctl
+	)
+
+  file(GLOB driverlib source/ti/driverlib/*.c)


NACK! This must be conditional inclusion. Check other HAL for reference.

fabiobaltieri mentioned this pull request Feb 6, 2024

Add support for TI's LP_MSPM0G3507 zephyrproject-rtos/zephyr#68503

Closed

vaishnavachath self-assigned this Feb 7, 2024

fabiobaltieri requested review from fabiobaltieri and vaishnavachath February 7, 2024 09:46

msp-ti force-pushed the mspm0_upstream branch from 1edfb66 to 6c7fd87 Compare February 28, 2024 22:10

fabiobaltieri reviewed Feb 29, 2024

View reviewed changes

msp-ti force-pushed the mspm0_upstream branch from 6c7fd87 to 9f63112 Compare March 19, 2024 19:08

msp-ti force-pushed the mspm0_upstream branch from 9f63112 to 1a19e01 Compare April 23, 2024 14:25

vaishnavachath approved these changes Sep 17, 2024

View reviewed changes

vaishnavachath requested changes Sep 17, 2024

View reviewed changes

vaishnavachath previously approved these changes Sep 23, 2024

View reviewed changes

vaishnavachath self-requested a review September 23, 2024 13:10

zephyrbot mentioned this pull request Oct 10, 2024

TI MSPM0 Support zephyrproject-rtos/zephyr#79673

Open

msp-ti force-pushed the mspm0_upstream branch from a11116e to 5ca0e4b Compare November 4, 2024 15:54

vaishnavachath requested changes Nov 4, 2024

View reviewed changes

parthitce suggested changes Nov 28, 2024

View reviewed changes

msp-ti force-pushed the mspm0_upstream branch from 5ca0e4b to 1bceb95 Compare December 9, 2024 23:07

mspm0: Add MSPM0 support

65b33bd

Added MSPM0 DriverLib and header files to be used for MSPM0 devices. Signed-off-by: Jackson Farley <[email protected]>

msp-ti force-pushed the mspm0_upstream branch from 1bceb95 to 65b33bd Compare December 9, 2024 23:20

parthitce reviewed Dec 10, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mspm0: Add MSPM0 support #51

mspm0: Add MSPM0 support #51

msp-ti commented Feb 3, 2024

vaishnavachath commented Feb 7, 2024

msp-ti commented Feb 27, 2024

msp-ti commented Feb 28, 2024

fabiobaltieri Feb 29, 2024

msp-ti Mar 19, 2024

fabiobaltieri Mar 19, 2024

vaishnavachath commented Apr 9, 2024

JFMSP commented Apr 16, 2024

fabiobaltieri commented Apr 23, 2024

jadonk commented Jul 11, 2024

vaishnavachath left a comment

vaishnavachath Nov 4, 2024

vaishnavachath Nov 4, 2024

parthitce Nov 28, 2024

vaishnavachath commented Nov 4, 2024

vaishnavachath commented Nov 4, 2024

Quentis commented Nov 9, 2024

vaishnavachath commented Nov 18, 2024

parthitce left a comment

parthitce Nov 28, 2024

parthitce Nov 28, 2024

parthitce Nov 28, 2024

JFMSP Dec 9, 2024

parthitce Dec 10, 2024

parthitce Dec 10, 2024

		@@ -0,0 +1,246 @@
		This file provides licensing information on the code provided in this repository.

mspm0: Add MSPM0 support #51

Are you sure you want to change the base?

mspm0: Add MSPM0 support #51

Conversation

msp-ti commented Feb 3, 2024

vaishnavachath commented Feb 7, 2024

msp-ti commented Feb 27, 2024

msp-ti commented Feb 28, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vaishnavachath commented Apr 9, 2024

JFMSP commented Apr 16, 2024

fabiobaltieri commented Apr 23, 2024

jadonk commented Jul 11, 2024

vaishnavachath left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vaishnavachath commented Nov 4, 2024

vaishnavachath commented Nov 4, 2024

Quentis commented Nov 9, 2024

vaishnavachath commented Nov 18, 2024

parthitce left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment