-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zephyr: modify log type from info to debug #50
zephyr: modify log type from info to debug #50
Conversation
Please elaborate in the commit message why this "fix" is needed, I have hard time understanding why we need to change this. |
e1a74d9
to
a70fe5e
Compare
yes, you are right, I only modify log type. |
hi sirs, |
Can you please raise a manifest PR for this? And then once CI is green we can merge this. |
|
@@ -269,7 +269,7 @@ static void hostapd_cli_recv_pending(struct wpa_ctrl *ctrl, struct hostapd_data | |||
wpa_printf(MSG_DEBUG, "Received len: %d, msg_len:%d - %s->END\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GaofengZhangNXP Please change the commit subject to zephyr: modify log type from info to debug
now there the hostap mentioned twice which looks weird. As this is zephyr specific change, lets use the zephyr: ...
prefix here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GaofengZhangNXP please modify as jukkar's comment.
zephyr: modify log type from info to debug
@jukkar @krish2718 , if you haven't any other comments, please help merge it, thanks |
print too long msg when eap enterprise. we should not print the log, so set print type to debug. Signed-off-by: Gaofeng Zhang <[email protected]>
a70fe5e
to
6fd30ff
Compare
Hi @jukkar , please help review the patch, if you have not any concern, please help merge it, thank you very much. |
Hi @jukkar , please help review the patch, if you have not any other suggestion, please help merge it, thank you very much. |
Hi @krish2718 , @jukkar could you pls review and merge this change? thanks |
print too long msg when eap enterprise.
we should not print the log, so set print type to debug.