Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zephyr: modify log type from info to debug #50

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

GaofengZhangNXP
Copy link
Contributor

@GaofengZhangNXP GaofengZhangNXP commented Oct 10, 2024

print too long msg when eap enterprise.
we should not print the log, so set print type to debug.

@jukkar
Copy link
Member

jukkar commented Oct 10, 2024

Please elaborate in the commit message why this "fix" is needed, I have hard time understanding why we need to change this.

@GaofengZhangNXP GaofengZhangNXP changed the title hostap: fix print too long msg hostap: modify log type from info to debug Oct 10, 2024
@GaofengZhangNXP
Copy link
Contributor Author

Please elaborate in the commit message why this "fix" is needed, I have hard time understanding why we need to change this.

yes, you are right, I only modify log type.

@GaofengZhangNXP
Copy link
Contributor Author

hi sirs,
please review the patch, thanks

@krish2718
Copy link
Collaborator

Can you please raise a manifest PR for this? And then once CI is green we can merge this.

@GaofengZhangNXP
Copy link
Contributor Author

Can you please raise a manifest PR for this? And then once CI is green we can merge this.
manifest PR:
zephyrproject-rtos/zephyr#82594

@@ -269,7 +269,7 @@ static void hostapd_cli_recv_pending(struct wpa_ctrl *ctrl, struct hostapd_data
wpa_printf(MSG_DEBUG, "Received len: %d, msg_len:%d - %s->END\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GaofengZhangNXP Please change the commit subject to zephyr: modify log type from info to debug
now there the hostap mentioned twice which looks weird. As this is zephyr specific change, lets use the zephyr: ... prefix here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GaofengZhangNXP please modify as jukkar's comment.
zephyr: modify log type from info to debug

@GaofengZhangNXP
Copy link
Contributor Author

@jukkar @krish2718 , if you haven't any other comments, please help merge it, thanks

print too long msg when eap enterprise.
we should not print the log, so set print type to debug.

Signed-off-by: Gaofeng Zhang <[email protected]>
@GaofengZhangNXP GaofengZhangNXP changed the title hostap: modify log type from info to debug zephyr: modify log type from info to debug Dec 11, 2024
@GaofengZhangNXP
Copy link
Contributor Author

Hi @jukkar , please help review the patch, if you have not any concern, please help merge it, thank you very much.

@GaofengZhangNXP
Copy link
Contributor Author

Hi @jukkar , please help review the patch, if you have not any other suggestion, please help merge it, thank you very much.

@gannicus-gj
Copy link

Hi @krish2718 , @jukkar

could you pls review and merge this change? thanks

@jukkar jukkar merged commit 9f696a4 into zephyrproject-rtos:main Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants