[noup] zephyr: Create dedicated heap for supplicant #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create dedicated heap for supplicant operations. Signed-off-by: Ravi Dondaputi <[email protected]>
|
why we need this dedicated heap for supplicant? |
Updated the description to correct this. Since the kernel heap is shared across various subsystems, we cannot enforce a minimum availability for supplicant. Using a pre-allocated heap solves this problem. |
krish2718
reviewed
Jan 2, 2025
Comment on lines
+21
to
+26
| #if defined(CONFIG_NOCACHE_MEMORY) | ||
| K_HEAP_DEFINE_NOCACHE(wifi_nm_wpa_supplicant_mem_pool, CONFIG_WIFI_NM_WPA_SUPPLICANT_HEAP); | ||
| #else | ||
| K_HEAP_DEFINE(wifi_nm_wpa_supplicant_mem_pool, CONFIG_WIFI_NM_WPA_SUPPLICANT_HEAP); | ||
| #endif /* CONFIG_NOCACHE_MEMORY */ | ||
| #define WORD_SIZE 4 |
There was a problem hiding this comment.
we don't need nocache memory for supplicant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create dedicated heap for supplicant operations. Currently, WPA supplicant uses the k_malloc, which is shared across various subsystems, and we cannot enforce a minimum availability. Using a dedicated HEAP that can be pre-allocated solves this by always having necessary memory.