Cortex R52 and Rust library support #53
Conversation
This commit adds Rust build support for the Cortex-R52 CPU type. Signed-off-by: Matthew Richey <[email protected]>
This commit adds a new cmake function rust_cargo_library() to build a Rust staticlib library with cbindgen-generated header file, which can be linked into a C application. Signed-off-by: Matthew Richey <[email protected]>
|
Sorry I haven't gotten around to reviewing this until now. Both of these seem quite reasonable, although I don't have a way to directly test. Is there a cortex-R target in Zephyr we can use to do a build test in CI? |
|
Don't worry about the Doc preview. I need to work with Zephyr ops to figure out how to get PRs from clones to have the credentials. |
|
Thank you for reviewing. There are Zephyr Cortex R targets, but I'm not sure about what CI resources are available to run Cortex R builds. Also I do not know much about how the Zephyr project automates its testing or what CI-related requirements they specify for public code submissions. I am sure this is documented somewhere, I'll need to look for it. Generally, as far as you know, do all repos in the |
:) |
|
Hi everyone. What can I do to build some more traction on this PR? Discussion so far has been about CI, are we stalled here? What exactly needs to be done on the CI front to move this forward? Thanks! |
|
So, ci is two parts. One is the 'build' task of CI. That needs to be fixed. If the docs make it all the way to failing with s3 then that is another issue (the credentials aren't available to PRs that come from other repos, like pull requests. I am seeing CI failures that might be due to other problems in the repo. I'm going to restart the build run and see where we are at now. |
|
@matthewjrichey It doesn't seem that I can restart the build. If you get a chance, can you rebase and push again, and we can try to address any build issues, whether due to this change, or just in genera. |
In this pull request I have added: