Camera interface esp32s3 #144038
Annotations
16 errors, 11 warnings, and 4 notices
drivers/video/Kconfig.esp32_dvp#L6
drivers/video/Kconfig.esp32_dvp:6 trailing whitespace
|
drivers/video/video_esp32_dvp.c#L348
drivers/video/video_esp32_dvp.c:348 do not use C99 // comments
|
drivers/video/video_esp32_dvp.c#L349
drivers/video/video_esp32_dvp.c:349 do not use C99 // comments
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L6
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:6 code indent should use tabs where possible
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L7
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:7 code indent should use tabs where possible
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L8
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:8 code indent should use tabs where possible
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L12
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:12 code indent should use tabs where possible
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L16
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:16 code indent should use tabs where possible
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L17
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:17 code indent should use tabs where possible
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L18
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:18 code indent should use tabs where possible
|
Nits.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
Missing newline at end of 'samples/drivers/video/capture/boards/xiao_esp32s3_procpu.conf'. Check your text editor settings.
|
Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
TRAILING_WHITESPACE: trailing whitespace
File:drivers/video/Kconfig.esp32_dvp
Line:6
LONG_LINE: line length of 161 exceeds 100 columns
File:drivers/video/video_esp32_dvp.c
Line:175
C99_COMMENTS: do not use C99 // comments
File:drivers/video/video_esp32_dvp.c
Line:348
C99_COMMENTS: do not use C99 // comments
File:drivers/video/video_esp32_dvp.c
Line:349
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:5
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:6
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:6
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:7
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:7
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:8
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:8
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:9
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:12
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:12
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:16
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:16
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:17
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:17
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:18
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:18
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:19
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:19
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:20
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:21
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:21
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:22
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:22
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:23
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:23
CODE_INDENT: code indent should use tabs where possible
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:24
LEADING_SPACE: please, no spaces at the start of a line
File:samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay
Line:24
|
Gitlint.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
Commit 706f357076:
1: T6 Title has leading whitespace: " sample: video: esp32s3: add support for xiao_esp32s3"
|
Identity.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
8a690bbb63939b31a8c2f9095864abac57158d83: author email (Armin Kessler <[email protected]>) needs to match one of the signed-off-by entries.
706f3570764757a48b3bf33f3f2a498001e80222: author email (Armin Kessler <[email protected]>) needs to match one of the signed-off-by entries.
631e6a9e3a79244fb10765285807b3486cba2268: author email (Armin Kessler <[email protected]>) needs to match one of the signed-off-by entries.
|
GitDiffCheck.txt#L1
Git conflict markers and whitespace errors are not allowed in added changes
9e8f10be978e53cfca1383216ea9cb89462711b5: drivers/video/Kconfig.esp32_dvp:6: trailing whitespace.
|
|
drivers/video/video_esp32_dvp.c#L175
drivers/video/video_esp32_dvp.c:175 line length of 161 exceeds 100 columns
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L5
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:5 please, no spaces at the start of a line
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L6
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:6 please, no spaces at the start of a line
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L7
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:7 please, no spaces at the start of a line
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L8
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:8 please, no spaces at the start of a line
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L9
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:9 please, no spaces at the start of a line
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L12
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:12 please, no spaces at the start of a line
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L16
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:16 please, no spaces at the start of a line
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L17
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:17 please, no spaces at the start of a line
|
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay#L18
samples/drivers/video/capture/boards/xiao_esp32s3_procpu.overlay:18 please, no spaces at the start of a line
|
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
- LCD_CAM.cam_ctrl.cam_clk_sel =
- ESP32_CAM_CLK_OFF_SEL;
+ LCD_CAM.cam_ctrl.cam_clk_sel = ESP32_CAM_CLK_OFF_SEL;
File:drivers/clock_control/clock_control_esp32_cam.c
Line:44
You may want to run clang-format on this change:
- LOG_ERR("Not enough descriptors available. Increase CONFIG_DMA_ESP32_MAX_DESCRIPTOR_NUM by %d", buffer_size / VIDEO_ESP32_DMA_BUFFER_MAX_SIZE+1);
+ LOG_ERR("Not enough descriptors available. Increase "
+ "CONFIG_DMA_ESP32_MAX_DESCRIPTOR_NUM by %d",
+ buffer_size / VIDEO_ESP32_DMA_BUFFER_MAX_SIZE + 1);
File:drivers/video/video_esp32_dvp.c
Line:176
You may want to run clang-format on this change:
- cam_ll_set_vh_de_mode(cam_dev, 0); // Disable vh_de mode default
+ cam_ll_set_vh_de_mode(cam_dev, 0); // Disable vh_de mode default
cam_ll_enable_rgb_yuv_convert(cam_dev, 0); // bypass conv module
-
File:drivers/video/video_esp32_dvp.c
Line:351
You may want to run clang-format on this change:
- fmt.width = 160;
+ fmt.width = 160;
fmt.height = 120;
fmt.pitch = fmt.width * 2;
fmt.pixelformat = VIDEO_PIX_FMT_RGB565;
- if(video_set_format(video_dev, VIDEO_EP_OUT, &fmt)){
- LOG_ERR("Unable to set format");
- return 0;
- }
-
- printk("- Set format: %c%c%c%c %ux%u\n", (char)fmt.pixelformat,
+ if (video_set_format(video_dev, VIDEO_EP_OUT, &fmt)) {
+ LOG_ERR("Unable to set format");
+ return 0;
+ }
+
+ printk("- Set format: %c%c%c%c %ux%u\n", (char)fmt.pixelformat,
File:samples/drivers/video/capture/src/main.c
Line:158
|
drivers/clock_control/clock_control_esp32_cam.c#L44
drivers/clock_control/clock_control_esp32_cam.c:44
- LCD_CAM.cam_ctrl.cam_clk_sel =
- ESP32_CAM_CLK_OFF_SEL;
+ LCD_CAM.cam_ctrl.cam_clk_sel = ESP32_CAM_CLK_OFF_SEL;
|
drivers/video/video_esp32_dvp.c#L176
drivers/video/video_esp32_dvp.c:176
- LOG_ERR("Not enough descriptors available. Increase CONFIG_DMA_ESP32_MAX_DESCRIPTOR_NUM by %d", buffer_size / VIDEO_ESP32_DMA_BUFFER_MAX_SIZE+1);
+ LOG_ERR("Not enough descriptors available. Increase "
+ "CONFIG_DMA_ESP32_MAX_DESCRIPTOR_NUM by %d",
+ buffer_size / VIDEO_ESP32_DMA_BUFFER_MAX_SIZE + 1);
|
drivers/video/video_esp32_dvp.c#L351
drivers/video/video_esp32_dvp.c:351
- cam_ll_set_vh_de_mode(cam_dev, 0); // Disable vh_de mode default
+ cam_ll_set_vh_de_mode(cam_dev, 0); // Disable vh_de mode default
cam_ll_enable_rgb_yuv_convert(cam_dev, 0); // bypass conv module
-
|
samples/drivers/video/capture/src/main.c#L158
samples/drivers/video/capture/src/main.c:158
- fmt.width = 160;
+ fmt.width = 160;
fmt.height = 120;
fmt.pitch = fmt.width * 2;
fmt.pixelformat = VIDEO_PIX_FMT_RGB565;
- if(video_set_format(video_dev, VIDEO_EP_OUT, &fmt)){
- LOG_ERR("Unable to set format");
- return 0;
- }
-
- printk("- Set format: %c%c%c%c %ux%u\n", (char)fmt.pixelformat,
+ if (video_set_format(video_dev, VIDEO_EP_OUT, &fmt)) {
+ LOG_ERR("Unable to set format");
+ return 0;
+ }
+
+ printk("- Set format: %c%c%c%c %ux%u\n", (char)fmt.pixelformat,
|
This job failed
Loading