drivers: video: sw_generator: Hue Saturation Brightness controls #153113
Annotations
4 errors, 3 warnings, and 6 notices
|
Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
LONG_LINE: line length of 104 exceeds 100 columns
File:tests/subsys/dsp/macros/src/q7.c
Line:102
LONG_LINE: line length of 104 exceeds 100 columns
File:tests/subsys/dsp/macros/src/q7.c
Line:106
|
Nits.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
Missing newline at end of 'tests/subsys/dsp/macros/src/q15.c'. Check your text editor settings.
Missing newline at end of 'tests/subsys/dsp/macros/src/q31.c'. Check your text editor settings.
|
|
tests/subsys/dsp/macros/src/q7.c#L102
tests/subsys/dsp/macros/src/q7.c:102 line length of 104 exceeds 100 columns
|
tests/subsys/dsp/macros/src/q7.c#L106
tests/subsys/dsp/macros/src/q7.c:106 line length of 104 exceeds 100 columns
|
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
-#define HUE(a) Q15f((double)(a) / 360.)
+#define HUE(a) Q15f((double)(a) / 360.)
#define SMPTE_NUM 7
static const q15_t smpte_colorbar_hsv[3][SMPTE_NUM] = {
/* white, yellow, cyan, green, magenta, red, blue */
- {HUE(0), HUE(60), HUE(180), HUE(120), HUE(300), HUE(0), HUE(240)},
+ {HUE(0), HUE(60), HUE(180), HUE(120), HUE(300), HUE(0), HUE(240)},
File:drivers/video/video_sw_generator.c
Line:37
You may want to run clang-format on this change:
- .pixelformat = (fourcc), .width_min = 64, .width_max = 1920, .height_min = 1, \
- .height_max = 1080, .width_step = 1, .height_step = 1, \
+ .pixelformat = (fourcc), \
+ .width_min = 64, \
+ .width_max = 1920, \
+ .height_min = 1, \
+ .height_max = 1080, \
+ .width_step = 1, \
+ .height_step = 1, \
File:drivers/video/video_sw_generator.c
Line:62
You may want to run clang-format on this change:
- LOG_DBG("H%1"PRIq(3)" S%1"PRIq(3)" V%1"PRIq(3)", "
- "R%1"PRIq(3)" G%1"PRIq(3)" B%1"PRIq(3)", "
- "Y%1"PRIq(3)" U%1"PRIq(3)" V%1"PRIq(3),
+ LOG_DBG("H%1" PRIq(3) " S%1" PRIq(3) " V%1" PRIq(
+ 3) ", "
+ "R%1" PRIq(3) " G%1" PRIq(3) " B%1" PRIq(
+ 3) ", "
+ "Y%1" PRIq(3) " U%1" PRIq(3) " V%1" PRIq(3),
PRIq_arg(hue, 3, 0), PRIq_arg(sat, 3, 0), PRIq_arg(val, 3, 0),
- PRIq_arg(r, 3, 0), PRIq_arg(g, 3, 0), PRIq_arg(b, 3, 0),
- PRIq_arg(y, 3, 0), PRIq_arg(u, 3, 0), PRIq_arg(v, 3, 0));
+ PRIq_arg(r, 3, 0), PRIq_arg(g, 3, 0), PRIq_arg(b, 3, 0), PRIq_arg(y, 3, 0),
+ PRIq_arg(u, 3, 0), PRIq_arg(v, 3, 0));
File:drivers/video/video_sw_generator.c
Line:223
You may want to run clang-format on this change:
-#define SCALE(i, imin, imax, omin, omax) \
+#define SCALE(i, imin, imax, omin, omax) \
File:include/zephyr/sys/util.h
Line:432
You may want to run clang-format on this change:
-#define MAP_VALUE(i, imin, imax, omin, omax) \
+#define MAP_VALUE(i, imin, imax, omin, omax) \
File:include/zephyr/sys/util.h
Line:461
You may want to run clang-format on this change:
- zassert_within(INTq7(Q7i(INT32_MIN, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), INT32_MIN, e);
+ zassert_within(INTq7(Q7i(INT32_MIN, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), INT32_MIN,
+ e);
zassert_within(INTq7(Q7i(-1032, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), -1032, e);
zassert_within(INTq7(Q7i(0, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), 0, e);
zassert_within(INTq7(Q7i(1032, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), 1032, e);
- zassert_within(INTq7(Q7i(INT32_MAX, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), INT32_MAX, e);
+ zassert_within(INTq7(Q7i(INT32_MAX, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), INT32_MAX,
+ e);
File:tests/subsys/dsp/macros/src/q7.c
Line:107
|
drivers/video/video_sw_generator.c#L37
drivers/video/video_sw_generator.c:37
-#define HUE(a) Q15f((double)(a) / 360.)
+#define HUE(a) Q15f((double)(a) / 360.)
#define SMPTE_NUM 7
static const q15_t smpte_colorbar_hsv[3][SMPTE_NUM] = {
/* white, yellow, cyan, green, magenta, red, blue */
- {HUE(0), HUE(60), HUE(180), HUE(120), HUE(300), HUE(0), HUE(240)},
+ {HUE(0), HUE(60), HUE(180), HUE(120), HUE(300), HUE(0), HUE(240)},
|
drivers/video/video_sw_generator.c#L62
drivers/video/video_sw_generator.c:62
- .pixelformat = (fourcc), .width_min = 64, .width_max = 1920, .height_min = 1, \
- .height_max = 1080, .width_step = 1, .height_step = 1, \
+ .pixelformat = (fourcc), \
+ .width_min = 64, \
+ .width_max = 1920, \
+ .height_min = 1, \
+ .height_max = 1080, \
+ .width_step = 1, \
+ .height_step = 1, \
|
drivers/video/video_sw_generator.c#L223
drivers/video/video_sw_generator.c:223
- LOG_DBG("H%1"PRIq(3)" S%1"PRIq(3)" V%1"PRIq(3)", "
- "R%1"PRIq(3)" G%1"PRIq(3)" B%1"PRIq(3)", "
- "Y%1"PRIq(3)" U%1"PRIq(3)" V%1"PRIq(3),
+ LOG_DBG("H%1" PRIq(3) " S%1" PRIq(3) " V%1" PRIq(
+ 3) ", "
+ "R%1" PRIq(3) " G%1" PRIq(3) " B%1" PRIq(
+ 3) ", "
+ "Y%1" PRIq(3) " U%1" PRIq(3) " V%1" PRIq(3),
PRIq_arg(hue, 3, 0), PRIq_arg(sat, 3, 0), PRIq_arg(val, 3, 0),
- PRIq_arg(r, 3, 0), PRIq_arg(g, 3, 0), PRIq_arg(b, 3, 0),
- PRIq_arg(y, 3, 0), PRIq_arg(u, 3, 0), PRIq_arg(v, 3, 0));
+ PRIq_arg(r, 3, 0), PRIq_arg(g, 3, 0), PRIq_arg(b, 3, 0), PRIq_arg(y, 3, 0),
+ PRIq_arg(u, 3, 0), PRIq_arg(v, 3, 0));
|
include/zephyr/sys/util.h#L432
include/zephyr/sys/util.h:432
-#define SCALE(i, imin, imax, omin, omax) \
+#define SCALE(i, imin, imax, omin, omax) \
|
include/zephyr/sys/util.h#L461
include/zephyr/sys/util.h:461
-#define MAP_VALUE(i, imin, imax, omin, omax) \
+#define MAP_VALUE(i, imin, imax, omin, omax) \
|
tests/subsys/dsp/macros/src/q7.c#L107
tests/subsys/dsp/macros/src/q7.c:107
- zassert_within(INTq7(Q7i(INT32_MIN, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), INT32_MIN, e);
+ zassert_within(INTq7(Q7i(INT32_MIN, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), INT32_MIN,
+ e);
zassert_within(INTq7(Q7i(-1032, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), -1032, e);
zassert_within(INTq7(Q7i(0, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), 0, e);
zassert_within(INTq7(Q7i(1032, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), 1032, e);
- zassert_within(INTq7(Q7i(INT32_MAX, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), INT32_MAX, e);
+ zassert_within(INTq7(Q7i(INT32_MAX, INT32_MIN, INT32_MAX), INT32_MIN, INT32_MAX), INT32_MAX,
+ e);
|
This job failed
Loading