Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf52: i2c_twim: Fix static 400uA current #72621

Closed
wants to merge 1 commit into from

Conversation

gumulka
Copy link
Contributor

@gumulka gumulka commented May 11, 2024

Hardware error described here:
https://infocenter.nordicsemi.com/topic/errata_nRF52832_Rev2/ERR/nRF52832/Rev2/latest/anomaly_832_89.html

When using GPIOTE and TWIM and PM_DEVICE, then the device must be turned off and then on again after suspending, otherwise there is a constant 400uA current draw.

This should be seen in cooperation with zephyrproject-rtos/hal_nordic#180

@MaureenHelm
Copy link
Member

This should be seen in cooperation with zephyrproject-rtos/hal_nordic#180

Then you probably need to update west.yml accordingly

@anangl please take a look

@gumulka
Copy link
Contributor Author

gumulka commented Jun 4, 2024

Then you probably need to update west.yml accordingly

I did not want to link to a non-main branch in here, therefor I did not change it yet.

@MaureenHelm
Copy link
Member

Then you probably need to update west.yml accordingly

I did not want to link to a non-main branch in here, therefor I did not change it yet.

Please see https://docs.zephyrproject.org/latest/develop/modules.html#submitting-changes-to-modules

@zephyrbot
Copy link
Collaborator

zephyrbot commented Jun 8, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nordic zephyrproject-rtos/hal_nordic@4a3ba8e zephyrproject-rtos/hal_nordic#180 zephyrproject-rtos/hal_nordic#180/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nordic DNM This PR should not be merged (Do Not Merge) labels Jun 8, 2024
@gumulka
Copy link
Contributor Author

gumulka commented Jun 8, 2024

Please see https://docs.zephyrproject.org/latest/develop/modules.html#submitting-changes-to-modules

Thank you. I was not aware of this. The DNM Label is now added and everything should be fine, I just need someone to review it.

@MaureenHelm
Copy link
Member

Please see docs.zephyrproject.org/latest/develop/modules.html#submitting-changes-to-modules

Thank you. I was not aware of this. The DNM Label is now added and everything should be fine, I just need someone to review it.

You need to address the twister build failures

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@gumulka
Copy link
Contributor Author

gumulka commented Oct 9, 2024

You need to address the twister build failures

Finally managed to do just that. Now it really just needs a reviewer. :)

Could you remove the "stale" label?

Hardware error described here:
https://docs.nordicsemi.com/bundle/errata_nRF52832_Rev3/page/ERR/nRF52832/Rev3/latest/anomaly_832_89.html

When using GPIOTE and TWIM and PM_DEVICE, then the device must be
turned off and then on again after suspending, otherwise there is a
constant 400uA current draw.

Signed-off-by: Fabian Pflug <[email protected]>
@gumulka
Copy link
Contributor Author

gumulka commented Nov 22, 2024

@anangl could I get a review from someone?

@anangl
Copy link
Member

anangl commented Nov 25, 2024

@anangl could I get a review from someone?

Please see this comment: zephyrproject-rtos/hal_nordic#180 (comment).

@gumulka gumulka closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: I2C DNM This PR should not be merged (Do Not Merge) manifest manifest-hal_nordic platform: nRF Nordic nRFx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants