Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intel_adsp: ace30: Bring up ACE 3.0 (PTL) #73540

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

ceolin
Copy link
Member

@ceolin ceolin commented May 30, 2024

This commit adds definition of ACE 3.0 Panther Lake board.

Signed-off-by: Anas Nashif [email protected]
Signed-off-by: Flavio Ceolin [email protected]

@andyross
Copy link
Contributor

Doing a cut/paste check of the added files vs. ace20_lnl files:

  • adsp_boot.h, adsp_ipc_regs.h and adsp_memory_regions.h are identical files, modulo stuff like whitespace and copyright dates.

  • dmic_regs_ace3x.h is an identical file, and was given a new file name needlessly!

  • adsp_interrupt.h and adsp_memory.h differ only in register address #defines, which should be in devicetree anyway.

Really the only meaninful deltas I can see are in adsp_power and adsp_shim.

Maybe clean this up before merge? Duplicated code makes interfaces difficult to evolve, and is one of the reasons that older DSP platforms like cAVS 1.8[1] are no longer in the tree and cut off from new development.

Not a -1 as it's not my platform, but this kind of gives me an ick.

[1] By far the most popular chromebook platform in the field! And it will never see new Zephyr/SOF features.

@ceolin
Copy link
Member Author

ceolin commented May 31, 2024

Doing a cut/paste check of the added files vs. ace20_lnl files:

  • adsp_boot.h, adsp_ipc_regs.h and adsp_memory_regions.h are identical files, modulo stuff like whitespace and copyright dates.

That was from a wrong rebase :/ They were correct in the first version :p

  • dmic_regs_ace3x.h is an identical file, and was given a new file name needlessly!
  • adsp_interrupt.h and adsp_memory.h differ only in register address #defines, which should be in devicetree anyway.

Flavio Ceolin and others added 2 commits May 31, 2024 10:41
This commit adds definition of ACE 3.0 Panther Lake board.

Signed-off-by: Anas Nashif <[email protected]>
Signed-off-by: Flavio Ceolin <[email protected]>
Add dmic support in PTL.

Signed-off-by: Flavio Ceolin <[email protected]>
Signed-off-by: Jaroslaw Stelter <[email protected]>
headers for dmic are now part of the SoC and maintained per generation,
so create one header for PTL and build the code for PTL in some of the
drivers (dmic_nhlt).

Signed-off-by: Anas Nashif <[email protected]>
jxstelter and others added 3 commits May 31, 2024 10:50
In the Intel platforms most of HPSRAM is used by modules when
are required. By default all these banks are powered off and are
enabled by L2 MM driver only when needed.

At the driver initialisation each unused page is unmaped and
when whole HPSRAM bank is unused the power is switched off.

Since mapping memory in MMU TLB and flushing it at system start is
not needed and time consuming, this patch modifies the init
sequence to avoid it.

Additionally it adds MMU maping and unmaping for pages allocated
from unused pool.

Signed-off-by: Flavio Ceolin <[email protected]>
Signed-off-by: Jaroslaw Stelter <[email protected]>
Signed-off-by: Anas Nashif <[email protected]>
This commit refactors the Intel SSP DAI driver to support dynamic
management of SSP IP. This change additionally separates the
management of the DAI part from the management part of the SSP IP.

Key changes:
- Add new static functions to manage SSP IP power.
- Update the DAI SSP configuration functions to use the new management
  approach.
- Update device tree bindings and instances to reflect the new SSP IP
  management mechanism.
- ace30 (PTL) support.

Signed-off-by: Flavio Ceolin <[email protected]>
Signed-off-by: Anas Nashif <[email protected]>
Signed-off-by: Jaroslaw Stelter <[email protected]>
Set the appropriated toolchain name for each ace target.

Signed-off-by: Flavio Ceolin <[email protected]>
@marc-hb
Copy link
Collaborator

marc-hb commented Jun 4, 2024

Duplicated code makes interfaces difficult to evolve

Also:

@nashif nashif assigned nashif and dcpleung and unassigned kv2019i and nashif Jun 4, 2024
@henrikbrixandersen henrikbrixandersen merged commit adabe57 into zephyrproject-rtos:main Jun 4, 2024
22 checks passed
@marc-hb
Copy link
Collaborator

marc-hb commented Jun 21, 2024

Maybe clean this up before merge? Duplicated code makes interfaces difficult to evolve, and is one of the reasons that older DSP platforms like cAVS 1.8[1] are no longer in the tree and cut off from new development.

Small bug fix:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants