Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: espressif: esp32: fix SPIRAM allocation #74670

Conversation

marekmatej
Copy link

@marekmatej marekmatej commented Jun 21, 2024

Fixing the SPIRAM allocation by moving the output section before tha data is spilled in the generic output section.
The issue is described here: #74675

Fixing the SPIRAM allocation by moving the output section
before tha data is spilled in the generic output section.

Signed-off-by: Marek Matej <[email protected]>
@marekmatej marekmatej added the DNM This PR should not be merged (Do Not Merge) label Jun 21, 2024
@aescolar
Copy link
Member

aescolar commented Jul 9, 2024

@LucasTambor @uLipe please review

@uLipe
Copy link
Collaborator

uLipe commented Jul 9, 2024

LGTM

@sylvioalves
Copy link
Collaborator

Keep this as DNM until we make sure it is all good (re-check).

@nashif nashif removed this from the v3.7.0 milestone Jul 16, 2024
@nashif nashif added the backport v3.7-branch Request backport to the v3.7-branch label Jul 16, 2024
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Sep 15, 2024
@sam-golioth
Copy link

Is this still being worked on?

@marekmatej
Copy link
Author

Is this still being worked on?

Yeah, it is a part of a bigger picture.

@sam-golioth
Copy link

Is this still being worked on?

Yeah, it is a part of a bigger picture.

Glad to hear! Do you have a link to the PR or issue for the bigger picture? Will that work be done in time for Zephyr v3.7.1 (in 2 weeks)?

@github-actions github-actions bot removed the Stale label Sep 17, 2024
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Nov 18, 2024
@kartben
Copy link
Collaborator

kartben commented Nov 25, 2024

@marekmatej is the DNM still appropriate?

@sylvioalves
Copy link
Collaborator

@marekmatej is the DNM still appropriate?

Yes, please. Some additional work will be added here.

@github-actions github-actions bot removed the Stale label Nov 26, 2024
@marekmatej
Copy link
Author

I'm closing this PR as #82870 takes care of ESP32 and ESP32-S3.

@marekmatej marekmatej closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v3.7-branch Request backport to the v3.7-branch DNM This PR should not be merged (Do Not Merge) platform: ESP32 Espressif ESP32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants