samples: drivers: video: capture: Add format config #77879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Samples
zephyrbot
requested review from
andyross,
ceolin,
dcpleung,
gmarull,
kartben,
loicpoulain,
marekmatej,
nashif,
raffarost,
uLipe and
wmrsouza
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
josuah
reviewed
Sep 11, 2024
LucasTambor
force-pushed
the
sample/video_capture
branch
from
c9181a8 to
a8161f7
Compare
LucasTambor
force-pushed
the
sample/video_capture
branch
from
a8161f7 to
27f4438
Compare
uLipe
previously approved these changes
Sep 25, 2024
LucasTambor
dismissed stale reviews from uLipe, wmrsouza, sylvioalves, and josuah
via
417cbf6
LucasTambor
force-pushed
the
sample/video_capture
branch
from
2cd5d37 to
417cbf6
Compare
sylvioalves
previously approved these changes
Sep 26, 2024
josuah
previously approved these changes
Sep 26, 2024
wmrsouza
previously approved these changes
Sep 26, 2024
uLipe
previously approved these changes
Sep 26, 2024
kartben
requested changes
Sep 30, 2024
Comment on lines
8
to
12
| config VIDEO_FORMAT_HEIGHT | ||
| int "Height of the video format" | ||
| default 0 | ||
| help | ||
| Height of the video format. If set to 0, the default height is used. |
There was a problem hiding this comment.
This is very oddly worded?
Suggested change
| config VIDEO_FORMAT_HEIGHT | |
| int "Height of the video format" | |
| default 0 | |
| help | |
| Height of the video format. If set to 0, the default height is used. | |
| config VIDEO_FRAME_HEIGHT | |
| int "Height of the video frames" | |
| default 0 | |
| help | |
| Height of the video frames. If set to 0, the default height is used. |
Comment on lines
14
to
18
| config VIDEO_FORMAT_WIDTH | ||
| int "Width of the video format" | ||
| default 0 | ||
| help | ||
| Width of the video format. If set to 0, the default width is used. |
Comment on lines
20
to
23
| config VIDEO_PIXEL_FORMAT | ||
| string "Pixel format of the video format" | ||
| help | ||
| Pixel format of the video format. If not set, the default pixel format is used. |
There was a problem hiding this comment.
Suggested change
| config VIDEO_PIXEL_FORMAT | |
| string "Pixel format of the video format" | |
| help | |
| Pixel format of the video format. If not set, the default pixel format is used. | |
| config VIDEO_PIXEL_FORMAT | |
| string "Pixel format of the video frames" | |
| help | |
| Pixel format of the video frames. If not set, the default pixel format is used. |
Add video format Kconfig for proper sample configuration. Signed-off-by: Lucas Tamborrino <[email protected]>
Fix build warning for unused variables. Signed-off-by: Lucas Tamborrino <[email protected]>
Add video as supported feature. Signed-off-by: Lucas Tamborrino <[email protected]>
Add support for esp32s3-eye board. Signed-off-by: Lucas Tamborrino <[email protected]>
LucasTambor
dismissed stale reviews from uLipe, wmrsouza, josuah, and sylvioalves
via
502d63e
LucasTambor
force-pushed
the
sample/video_capture
branch
from
417cbf6 to
502d63e
Compare
kartben
approved these changes
Sep 30, 2024
raffarost
approved these changes
Sep 30, 2024
josuah
approved these changes
Sep 30, 2024
sylvioalves
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add video format Kconfig for proper sample configuration.