tests: boards: nrf: coresight_stm: Add performance test for STM #79000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordic-segl
force-pushed
the
NRFX-6024_Add-STM-regression-test
branch
from
8a37cee to
0a42cc8
Compare
nordic-segl
force-pushed
the
NRFX-6024_Add-STM-regression-test
branch
from
0a42cc8 to
1c5a065
Compare
zephyrbot
requested review from
anangl,
jaz1-nordic,
kartben,
kl-cruz,
magp-nordic,
masz-nordic,
nashif and
nika-nordic
nordic-segl
added a commit
to nordic-segl/sdk-zephyr
that referenced
this pull request
Oct 11, 2024
…t for STM Extend STM testing with verification whether STM benchmark results are below predefined thresholds. Set thresholds arbitrarily. Add tests that allow code coverage calculation. Upstream PR: zephyrproject-rtos/zephyr#79000 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 11, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-zephyr
that referenced
this pull request
Oct 14, 2024
…t for STM Extend STM testing with verification whether STM benchmark results are below predefined thresholds. Set thresholds arbitrarily. Add tests that allow code coverage calculation. Upstream PR: zephyrproject-rtos/zephyr#79000 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 14, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-zephyr
that referenced
this pull request
Oct 17, 2024
…t for STM Extend STM testing with verification whether STM benchmark results are below predefined thresholds. Set thresholds arbitrarily. Add tests that allow code coverage calculation. Upstream PR: zephyrproject-rtos/zephyr#79000 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 17, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-krch
previously approved these changes
Oct 17, 2024
nordic-segl
added a commit
to nordic-segl/sdk-zephyr
that referenced
this pull request
Oct 17, 2024
…t for STM Extend STM testing with verification whether STM benchmark results are below predefined thresholds. Set thresholds arbitrarily. Add tests that allow code coverage calculation. Upstream PR: zephyrproject-rtos/zephyr#79000 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 17, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-zephyr
that referenced
this pull request
Oct 18, 2024
…t for STM Extend STM testing with verification whether STM benchmark results are below predefined thresholds. Set thresholds arbitrarily. Add tests that allow code coverage calculation. Upstream PR: zephyrproject-rtos/zephyr#79000 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 18, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 6, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
|
Rebased, please do review. |
nordic-krch
previously approved these changes
Dec 9, 2024
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 10, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
force-pushed
the
NRFX-6024_Add-STM-regression-test
branch
from
a08e7ba to
7bd44e0
Compare
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 10, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
force-pushed
the
NRFX-6024_Add-STM-regression-test
branch
from
7bd44e0 to
72d3b5f
Compare
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 11, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-krch
previously approved these changes
Dec 11, 2024
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 11, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 11, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
masz-nordic
reviewed
Dec 11, 2024
Comment on lines
+11
to
+13
| if(NOT (CONFIG_BOARD_NRF54H20DK_NRF54H20_CPUAPP)) | ||
| message(FATAL_ERROR "${BOARD}${BOARD_QUALIFIERS} is not supported for this sample") | ||
| endif() |
There was a problem hiding this comment.
This is already specified in testcase.yaml so seems redundant.
There was a problem hiding this comment.
testcase.yaml is parsed by Twister only. This check is valid for both Twister and manual west build.
| SB_CONFIG_APP_CPUPPR_RUN = None | ||
| SB_CONFIG_APP_CPUFLPR_RUN = None | ||
|
|
||
| # https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/misc/coresight/nrf_etr.c#L102 |
There was a problem hiding this comment.
I suppose this is more about lines 99 and 101.
Perhaps using hex values below would be clearer as well.
There was a problem hiding this comment.
"I suppose this is more about lines 99 and 101." - there were changes to the nrf_etr.c in mean time which made this comment misleading. Maybe See definition of stm_m_id[] and stm_m_name[] in https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/misc/coresight/nrf_etr.c would be better.
Decimal values must be used with nrfutil trace --database-config XX:path_to_json,YY:path_to_json,ZZ:path_to_json.
I wanted to demonstrate how to map coprocessor into --database-config string rather than where these values come from.
nordic-segl
force-pushed
the
NRFX-6024_Add-STM-regression-test
branch
2 times, most recently
from
fdcd156 to
26c6574
Compare
Extend STM testing with verification whether STM benchmark results are below predefined thresholds. Set thresholds arbitrarily. Add tests that allow code coverage calculation. Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
force-pushed
the
NRFX-6024_Add-STM-regression-test
branch
from
26c6574 to
a57c64e
Compare
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 11, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 13, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-krch
approved these changes
Dec 13, 2024
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 13, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 13, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 16, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
kl-cruz
approved these changes
Dec 16, 2024
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 16, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Dec 16, 2024
tests: boards: nrf: coresight_stm: Add performance test for STM zephyrproject-rtos/zephyr#79000 nrfconnect/sdk-zephyr#2097 Signed-off-by: Sebastian Głąb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend STM testing with verification whether STM benchmark results are below predefined thresholds.
Set thresholds arbitrarily.
Add tests that allow code coverage calculation.