-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: adafruit feather nrf52840 uf2 initalize USB at boot #80038
boards: adafruit feather nrf52840 uf2 initalize USB at boot #80038
Conversation
CI fails are not caused by the changes from this PR. See #80215. |
Adafruit Feather nRF52840 UF2 variants have their USB enabled by default, and use the CDC ACM UART for console. All other nRF52840 boards that use that, initialize their USB by default. This change makes it so Adafruit Feather nRF52840 UF2 variants also do that. Signed-off-by: Sebastian Kwaśniak <[email protected]> Signed-off-by: Filip Kokosinski <[email protected]>
ad0c6ad
to
a9639d7
Compare
@jacobw can you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. |
Thanks for those links @jfischer-no. I get that in the end we'd prefer to have it done in a more tidy way. But right now we have a target that is essentially not working correctly, so IMO we should:
This way we'd avoid keeping a non-working target in-tree and waiting for the more complex effort to land in order to sort this situation out. WDYT? |
If you were to read the contents of the linked issue and commit messages in the linked PR, you would realize that this PR is not a correct fix at all. |
Closing because the issue this PR was addressing has been fixed in #81308. |
Make Adafruit Feather nrf52840 UF2 variants initialize USB by default.
Adafruit Feather nRF52840 UF2 variants have their USB enabled by default, and use the CDC ACM UART for the console. All other nRF52840 boards that use that, initialize their USB by default. This PR makes it so Adafruit Feather nRF52840 UF2 variants also do that.