Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: i2c: Base OMAP I2C support for TI-K3 series processor #80113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

drivers: i2c: Base OMAP I2C support for TI-K3 series processor #80113

wants to merge 3 commits into from
+843 −1

Conversation

malto101
Copy link
Contributor

@malto101 malto101 commented Oct 20, 2024 •
edited
Loading

This PR adds the support for I2C serial interface on TI K3 series. It is compatible with Philips I2C physical layer.
The commit includes:
Zephyr i2c api implementation
speed Select(100Kbps and 400Kbps)
Bus recovery

This driver is tested on BeagleBone AI64
Note: This PR is based #71527

@github-actions GitHub Actions
Copy link

Hello @malto101, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@malto101 malto101 marked this pull request as ready for review October 20, 2024 18:52
@zephyrbot zephyrbot added platform: TI SimpleLink Texas Instruments SimpleLink MCU platform: BeagleBoard BeagleBoard.org Foundation area: I2C labels Oct 20, 2024
@malto101 malto101 changed the title drivers: i2c: Base OMAP I2C support got Ti-K3 devices drivers: i2c: Base OMAP I2C support for TI-K3 series processor Oct 21, 2024
nordicjm
nordicjm reviewed Oct 21, 2024
View reviewed changes
drivers/i2c/Kconfig.omap Outdated Show resolved Hide resolved
@malto101 malto101 force-pushed the k3_i2c_omap branch 2 times, most recently from 04702a7 to b72aaf4 Compare October 21, 2024 07:19
vaishnavachath
vaishnavachath requested changes Oct 21, 2024
View reviewed changes
dts/arm/ti/j721e_main_r5.dtsi Outdated Show resolved Hide resolved
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
@malto101 malto101 force-pushed the k3_i2c_omap branch 5 times, most recently from 6d050eb to bf0b17b Compare October 21, 2024 13:43
vaishnavachath
vaishnavachath requested changes Oct 21, 2024
View reviewed changes
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
drivers/i2c/i2c_omap.c Show resolved Hide resolved
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
@malto101 malto101 force-pushed the k3_i2c_omap branch 5 times, most recently from b39ca6e to 715c86d Compare October 22, 2024 04:26
vaishnavachath
vaishnavachath previously approved these changes Dec 2, 2024
View reviewed changes
pdgendt
pdgendt reviewed Dec 2, 2024
View reviewed changes
drivers/i2c/i2c_omap.c Outdated Show resolved Hide resolved
vaishnavachath
vaishnavachath previously approved these changes Dec 2, 2024
View reviewed changes
vaishnavachath
vaishnavachath previously approved these changes Dec 8, 2024
View reviewed changes
pdgendt
pdgendt reviewed Dec 9, 2024
View reviewed changes
drivers/i2c/Kconfig.omap Outdated Show resolved Hide resolved
drivers/i2c/Kconfig.omap Outdated Show resolved Hide resolved
@malto101
Copy link
Contributor Author

hello @pdgendt, If everything looks fine, Could you approve the PR?

teburd
teburd previously approved these changes Dec 16, 2024
View reviewed changes
pdgendt
pdgendt previously approved these changes Dec 16, 2024
View reviewed changes
@malto101
drivers: i2c: Base OMAP I2C support for TI-K3 processor
bf6b1a7 
The OMAP I2C provides support for I2C serial interface on TI K3 series.
It is compatible with Philips I2C physical layer.
The commit includes:
Zephyr i2c api implementation
Polling Mode

Signed-off-by: Dhruv Menon <[email protected]>
@malto101
drivers: i2c: Added Bus recovery support to OMAP I2C.
e9e524f 
The bus recovery feature utilizing bit-bang operations, which sends
SCL clock pulses to recover the bus and checks if the line is down.
Upon recovery, it disables the system test register before resuming
the transactions.

Signed-off-by: Dhruv Menon <[email protected]>
@malto101
boards: beagle: Enable I2C6 on BeagleBone AI64 board
2ab31bd 
Provide I2C Support to BeagleBone AI64 board.

Signed-off-by: Dhruv Menon <[email protected]>
@malto101 malto101 dismissed stale reviews from pdgendt and teburd via 2ab31bd December 18, 2024 05:06
@malto101
Copy link
Contributor Author

malto101 commented Dec 18, 2024 •
edited
Loading

I have resolved the merge conflicts present in CMakeLists.txt and Kconfig, updated the branch, and pushed the changes.
CC: @teburd @pdgendt @vaishnavachath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdgendt pdgendt pdgendt approved these changes

@teburd teburd teburd left review comments

@Ayush1325 Ayush1325 Awaiting requested review from Ayush1325

@con-pax con-pax Awaiting requested review from con-pax

@vanti vanti Awaiting requested review from vanti

@nordicjm nordicjm Awaiting requested review from nordicjm

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@dnltz dnltz Awaiting requested review from dnltz

@nmenon nmenon Awaiting requested review from nmenon

@glneo glneo Awaiting requested review from glneo

@vaishnavachath vaishnavachath Awaiting requested review from vaishnavachath

Requested changes must be addressed to merge this pull request.

Assignees

@teburd teburd

Labels
area: I2C platform: BeagleBoard BeagleBoard.org Foundation platform: TI SimpleLink Texas Instruments SimpleLink MCU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@malto101 @dnltz @nmenon @teburd @henrikbrixandersen @glneo @pdgendt @vaishnavachath @nordicjm @zephyrbot