drivers: I2C: Order CMakeLists and KConfig in alphabetic order #80453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Organize all drivers in alphabetic order and move common parts at the beginning. Signed-off-by: Daniel Schultz <[email protected]>
Kconfig names follow the convention CONFIG_I2C_driver-name. Rename RENESAS_RA_I2C_IIC to I2C_RENESAS_RA_IIC to align this config name with all others. Signed-off-by: Daniel Schultz <[email protected]>
zephyrbot
added
area: I2C
platform: Renesas RA
zephyrbot
requested review from
duynguyenxa,
KhiemNguyenT,
soburi,
teburd and
thaoluonguw
thaoluonguw
approved these changes
Oct 28, 2024
soburi
reviewed
Nov 13, 2024
| @@ -6,107 +6,99 @@ zephyr_library() | |||
|
|
|||
| zephyr_library_sources(i2c_common.c) | |||
|
|
|||
| zephyr_library_sources_ifdef(CONFIG_GPIO_I2C_SWITCH gpio_i2c_switch.c) | |||
There was a problem hiding this comment.
Please consider to add
# zephyr-keep-sorted-start
Such like https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/gpio/Kconfig#L97
teburd
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch organizes the CMakeLists and Kconfig files in alphabetic order. This allows to better find and add new drivers to this list.
The second patch renames Renesas I2C Kconfig to align with the name convention CONFIG_I2C_driver-name.